Page MenuHomeFreeBSD

h_resolv: Fix a buffer overflow in load().
ClosedPublic

Authored by jhb on Dec 27 2022, 10:25 PM.
Tags
None
Referenced Files
F87401487: D37886.diff
Tue, Jul 2, 2:44 PM
F87369079: D37886.diff
Tue, Jul 2, 5:02 AM
Unknown Object (File)
May 9 2024, 9:55 AM
Unknown Object (File)
Apr 27 2024, 10:29 AM
Unknown Object (File)
Apr 27 2024, 10:29 AM
Unknown Object (File)
Apr 22 2024, 7:00 PM
Unknown Object (File)
Apr 22 2024, 6:48 PM
Unknown Object (File)
Apr 7 2024, 4:42 PM
Subscribers

Details

Summary

fgetln() returns a pointer to an array of characters that is 'len'
characters long, not 'len + 1'. While here, overwriting the contents
of the buffer returned by fgetln isn't really safe, so switch to using
getline() instead.

Note that these fixes are a subset of those applied to a
near-identical copy of this function in libc's resolv_test.c in commit
2afeaad315ac19450389b8f2befdbe7c91c37818.

Reported by: CHERI (buffer overflow)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable