Page MenuHomeFreeBSD

h_resolv: Fix a buffer overflow in load().
ClosedPublic

Authored by jhb on Dec 27 2022, 10:25 PM.
Tags
None
Referenced Files
F132089347: D37886.diff
Mon, Oct 13, 2:05 PM
Unknown Object (File)
Thu, Oct 9, 6:12 AM
Unknown Object (File)
Sat, Sep 20, 5:15 PM
Unknown Object (File)
Fri, Sep 19, 4:17 AM
Unknown Object (File)
Wed, Sep 17, 10:35 AM
Unknown Object (File)
Aug 2 2025, 10:22 AM
Unknown Object (File)
Aug 2 2025, 5:30 AM
Unknown Object (File)
Jul 22 2025, 8:45 PM
Subscribers

Details

Summary

fgetln() returns a pointer to an array of characters that is 'len'
characters long, not 'len + 1'. While here, overwriting the contents
of the buffer returned by fgetln isn't really safe, so switch to using
getline() instead.

Note that these fixes are a subset of those applied to a
near-identical copy of this function in libc's resolv_test.c in commit
2afeaad315ac19450389b8f2befdbe7c91c37818.

Reported by: CHERI (buffer overflow)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable