termcap.small: Don't use -o pipefail.
ClosedPublic
Actions

Authored by jhb on Dec 23 2022, 7:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 2, 8:40 AM

	Unknown Object (File)
	Sun, Nov 2, 8:37 AM

	Unknown Object (File)
	Wed, Oct 29, 10:20 AM

	Unknown Object (File)
	Wed, Oct 29, 8:13 AM

	Unknown Object (File)
	Mon, Oct 13, 2:21 AM

	Unknown Object (File)
	Fri, Oct 10, 4:34 AM

	Unknown Object (File)
	Fri, Oct 10, 4:34 AM

	Unknown Object (File)
	Fri, Oct 10, 4:34 AM

View All 84 Files

Subscribers

imp

Details

Reviewers

jrtc27
sobomax
imp

Commits

rG7a8d62cd0469: termcap.small: Don't use -o pipefail.

Summary

The command to generate termcap.small doesn't use any pipes, so this
option is not needed. Using it also breaks cross-building on hosts
where /bin/sh does not support pipefail such as Linux hosts where
/bin/sh is dash.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48876
Build 45765: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 23 2022, 7:48 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2022, 7:48 PM

jhb requested review of this revision.Dec 23 2022, 7:48 PM

Harbormaster completed remote builds in B48876: Diff 114517.Dec 23 2022, 7:48 PM

Looks good.

This revision is now accepted and ready to land.Dec 26 2022, 3:26 PM

Looks good to me too.

Closed by commit rG7a8d62cd0469: termcap.small: Don't use -o pipefail. (authored by jhb). · Explain WhyDec 27 2022, 6:05 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7a8d62cd0469: termcap.small: Don't use -o pipefail..

Revision Contents
Changeset List

Path

Size

etc/

termcap/

Makefile

2 lines

Diff 114517

View Options

termcap.small: Don't use -o pipefail.ClosedPublicActions