termcap.small: Don't use -o pipefail.
ClosedPublic
Actions

Authored by jhb on Dec 23 2022, 7:48 PM.

Details

Reviewers

jrtc27
sobomax
imp

Commits

rG7a8d62cd0469: termcap.small: Don't use -o pipefail.

Summary

The command to generate termcap.small doesn't use any pipes, so this
option is not needed. Using it also breaks cross-building on hosts
where /bin/sh does not support pipefail such as Linux hosts where
/bin/sh is dash.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 23 2022, 7:48 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 23 2022, 7:48 PM

jhb requested review of this revision.Dec 23 2022, 7:48 PM

Harbormaster completed remote builds in B48876: Diff 114517.Dec 23 2022, 7:48 PM

Looks good.

This revision is now accepted and ready to land.Dec 26 2022, 3:26 PM

Looks good to me too.

Closed by commit rG7a8d62cd0469: termcap.small: Don't use -o pipefail. (authored by jhb). · Explain WhyDec 27 2022, 6:05 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7a8d62cd0469: termcap.small: Don't use -o pipefail..

Revision Contents
Changeset List

Path

Size

etc/

termcap/

Makefile

2 lines

Diff 114575

View Options

etc/termcap/Makefile

	# Created by: kwm@FreeBSD.org			# Created by: kwm@FreeBSD.org
	# $FreeBSD$			# $FreeBSD$

	PORTNAME= wayland			PORTNAME= wayland
	PORTVERSION= 1.18.0			PORTVERSION= 1.18.0
	PORTREVISION= 2			PORTREVISION= 3
	CATEGORIES= graphics wayland			CATEGORIES= graphics wayland
	MASTER_SITES= https://wayland.freedesktop.org/releases/			MASTER_SITES= https://wayland.freedesktop.org/releases/

	PATCH_SITES= https://gitlab.freedesktop.org/${PORTNAME}/${PORTNAME}/commit/			PATCH_SITES= https://gitlab.freedesktop.org/${PORTNAME}/${PORTNAME}/commit/
	PATCHFILES+= 0fc00fff3015.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/60			PATCHFILES+= 0fc00fff3015.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/60
	PATCHFILES+= 1283d54dac97.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/61			PATCHFILES+= 1283d54dac97.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/61
	PATCHFILES+= 3a3dd0820de3.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/61			PATCHFILES+= 3a3dd0820de3.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/61
	PATCHFILES+= 230885ebb40b.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/61			PATCHFILES+= 230885ebb40b.patch:-p1 # https://gitlab.freedesktop.org/wayland/wayland/merge_requests/61
	Show All 19 Lines

termcap.small: Don't use -o pipefail.ClosedPublicActions