Page MenuHomeFreeBSD

framework: make llvm.mk aware of base compilers version not add dependency unnecessarily
ClosedPublic

Authored by tcberner on Dec 19 2022, 6:30 PM.
Tags
None
Referenced Files
F102757665: D37747.id114689.diff
Sat, Nov 16, 6:14 PM
Unknown Object (File)
Sat, Nov 9, 2:32 PM
Unknown Object (File)
Sun, Oct 27, 2:03 PM
Unknown Object (File)
Sun, Oct 27, 2:03 PM
Unknown Object (File)
Sun, Oct 27, 2:03 PM
Unknown Object (File)
Sun, Oct 27, 2:01 PM
Unknown Object (File)
Sun, Oct 27, 2:01 PM
Unknown Object (File)
Sun, Oct 27, 2:01 PM
Subscribers

Details

Summary

Heavily WIP.

Idea is to not add a dependency on devel/llvm* when base's clang is newer than the version llvm.mk calculated.

  • behaviour only affects :build and :run, not :lib.
  • behaviour can be turned off by :force.
Test Plan

Actually test :D

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This is a really good idea. The current llvm.mk causes some POLA problems for people who don't have DEFAULT_VERSIONS=llvm=... set, where suddenly llvm90 is being used to build things.

  • framework: rough conversion of the tree to llvm.mk
devel/lua-language-server/Makefile
40 ↗(On Diff #114688)

Is this really correct? How is USES=llvm to know that it needs llvm13? I am not totally understanding what USES=llvm is doing, but it seems like this points CPP/CC/CXX to binaries that the framework isn't ensuring are installed.

  • framework: cleanup of conversion 1/n
  • framework: cleanup of conversion 2/n (define LLVM_C* vars)
jbeich added inline comments.
emulators/wine-proton/Makefile
2 ↗(On Diff #114690)

Looks unrelated and would break build due to distinfo desync.

graphics/blender/Makefile
2 ↗(On Diff #114690)

Looks unrelated and would break build due to distinfo desync.

graphics/mesa-devel/Makefile
3 ↗(On Diff #114690)

Looks unrelated and would break build due to distinfo desync.

net-im/telegram-desktop/Makefile
2 ↗(On Diff #114690)

Looks unrelated and would break build due to distinfo desync.

Only export variables for now.

bofh added a subscriber: bofh.

I just ran a smaller exp-run with the specific ports of interest and Macro qaapproved:

This revision is now accepted and ready to land.Aug 25 2023, 9:16 AM