Page MenuHomeFreeBSD
Differential D37685

Fix per-FIB gateway support in rc.d/routing
ClosedPublic
Actions

Authored by andrew.fengler_scaleengine.com on Dec 13 2022, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 1:42 PM
Unknown Object (File)
Mon, Apr 8, 12:10 PM
Unknown Object (File)
Jan 25 2024, 11:06 PM
Unknown Object (File)
Dec 20 2023, 6:02 AM
Unknown Object (File)
Dec 12 2023, 10:20 AM
Unknown Object (File)
Aug 30 2023, 12:11 PM
Unknown Object (File)
Aug 26 2023, 5:06 AM
Unknown Object (File)
Jul 11 2023, 1:08 AM
View All 21 Files
Subscribers
imp
zlei

Details

Reviewers
freebsd_oldach.net
kevans
allanjude
Commits
rGe8deaa3c6b8b: rc.d/routing: Correct setting default gateway for each FIB
rGf81be7a8318b: rc.d/routing: Correct setting default gateway for each FIB
Summary

See: https://reviews.freebsd.org/D22706
There was a mistake in the previous diff. I'm not sure how that ended up that way, but there were a few mistakes in variable names. This patch will complete what was originally written and tested.

It changes 3 variable names to correctly use $_fib instead of $fib, and to prepend any ipv6 static routes, instead of ipv4 static routes to the the ipv6 route list.

Sorry for the mess.

Test Plan

This is what i originally tested in D22706.
It's running in production on several machines running 13.x

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew.fengler_scaleengine.com created this revision.Dec 13 2022, 5:30 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 13 2022, 5:30 PM
andrew.fengler_scaleengine.com requested review of this revision.Dec 13 2022, 5:30 PM
freebsd_oldach.net accepted this revision.Dec 13 2022, 6:13 PM
This revision is now accepted and ready to land.Dec 13 2022, 6:13 PM
allanjude accepted this revision.Jun 26 2023, 6:41 PM
Closed by commit rGf81be7a8318b: rc.d/routing: Correct setting default gateway for each FIB (authored by andrew.fengler_scaleengine.com, committed by allanjude). · Explain WhyJun 26 2023, 6:45 PM
This revision was automatically updated to reflect the committed changes.
allanjude added a commit: rGf81be7a8318b: rc.d/routing: Correct setting default gateway for each FIB.
zlei added a subscriber: zlei.Jun 29 2023, 3:57 AM

This fix should be MFCed into stable/13, as it fixes D22706 which has been cherry-picked into stable/13.

I'd suggest to add commit meta message MFC after to have mail reminders.

freebsd_oldach.net added a comment.Jul 28 2023, 4:22 AM

Can this please be MFCed to stable/13? As mentioned, this fixes a previous incorrect MFC.

zlei added a comment.Aug 29 2023, 8:16 AM
In D37685#938781, @freebsd_oldach.net wrote:

Can this please be MFCed to stable/13? As mentioned, this fixes a previous incorrect MFC.

No response from the committer for a long time.

I'll test and MFC if no objections.

zlei added a comment.Aug 30 2023, 12:16 PM

MFCed into stable/13 via commit e8deaa3c6b8b .

FreeBSD's Phabricator has some lag and does not reflect the commit.

zlei added a commit: rGe8deaa3c6b8b: rc.d/routing: Correct setting default gateway for each FIB.Aug 31 2023, 3:32 AM

Revision Contents
Changeset List

PathSize
libexec/
rc/
rc.d/
6 lines

Diff 123792

View Options

libexec/rc/rc.d/routing

Loading...