Page MenuHomeFreeBSD

stand: Make ioctl declaration consistent
ClosedPublic

Authored by imp on Dec 12 2022, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 7:53 AM
Unknown Object (File)
Fri, Jan 10, 7:40 PM
Unknown Object (File)
Sep 25 2024, 3:18 PM
Unknown Object (File)
Sep 16 2024, 3:46 PM
Unknown Object (File)
Sep 15 2024, 1:58 AM
Unknown Object (File)
Sep 15 2024, 1:58 AM
Unknown Object (File)
Sep 4 2024, 8:58 PM
Unknown Object (File)
Aug 23 2024, 8:11 PM
Subscribers

Details

Summary

It typically had two args with an optional third from the userland
declaration in sys/ioccom.h. However, the funciton definition used a
non-optional char * argument. This mismatch is UB behavior (but worked
due to the calling convetions of all our machines).

Instead, add a declaration for ioctl to stand.h, make the third arg
'void *' which is a better match to the ... declaration before. This
prevents the convert int * -> char * errors as well. Make the ioctl
user-space declaration truly user-space specific (omit it in the
stand-alone build).

No functional change intended.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable