HomeFreeBSD

stand: Make ioctl declaration consistent

Description

stand: Make ioctl declaration consistent

It typically had two args with an optional third from the userland
declaration in sys/ioccom.h. However, the funciton definition used a
non-optional char * argument. This mismatch is UB behavior (but worked
due to the calling convetions of all our machines).

Instead, add a declaration for ioctl to stand.h, make the third arg
'void *' which is a better match to the ... declaration before. This
prevents the convert int * -> char * errors as well. Make the ioctl
user-space declaration truly user-space specific (omit it in the
stand-alone build).

No functional change intended.

Sponsored by: Netflix
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D37680

(cherry picked from commit 2e1e68cbaee3e74a89e9b63fdb180974a2bf4292)

Details

Provenance
impAuthored on Dec 13 2022, 4:46 AM
Reviewer
emaste
Differential Revision
D37680: stand: Make ioctl declaration consistent
Parents
rGe68bfa6252a5: kboot: Use (void) instead of () for functiosn with no args
Branches
Unknown
Tags
Unknown