Page MenuHomeFreeBSD

Refresh the podman-suite parts with stability and functionality updates.
ClosedPublic

Authored by dfr on Nov 30 2022, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 6:34 PM
Unknown Object (File)
Fri, May 3, 6:34 PM
Unknown Object (File)
Fri, May 3, 6:34 PM
Unknown Object (File)
Fri, May 3, 6:34 PM
Unknown Object (File)
Fri, May 3, 8:06 AM
Unknown Object (File)
Fri, Apr 19, 11:00 AM
Unknown Object (File)
Fri, Apr 19, 11:00 AM
Unknown Object (File)
Fri, Apr 19, 11:00 AM
Subscribers

Details

Test Plan

Build with poudriere, test upgrade install, ad-hoc functionality testing.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dfr requested review of this revision.Nov 30 2022, 3:54 PM
zlei added inline comments.
net/containernetworking-plugins/files/pf.conf.sample
6 ↗(On Diff #113677)

@kp
Does pf nat automatically exclude (and reject) IPv6 link-local addresses from destination ?

net/containernetworking-plugins/files/pf.conf.sample
6 ↗(On Diff #113677)

Good question. I don't know offhand. I'm aware that pf can do IPv6 prefix translation, but I've never used it myself (or added tests for it).

I've taken a quick look at the code and can't immediately find anything that'd exclude link-local addresses.

On the other hand, pf might not need to care about them, at least for NAT, because we're never going to route to/from link-local addresses, and we're only going to NAT when we're routing.

net/containernetworking-plugins/files/pf.conf.sample
6 ↗(On Diff #113677)

I have tested this and it seems to do the right thing. The rule triggers if the packet is trying to leave the host and pf performs the NAT, replacing the source address with one from $v6egress_if.

Update containernetworking-plugins so that portmap works with the example pf.conf from v0.1

LGTM, keep the DISTVERSION/PORTVERSION consistent if possible.

sysutils/buildah/Makefile
2 ↗(On Diff #113757)

s/PORT/DIST/ ?

sysutils/podman/Makefile
2 ↗(On Diff #113757)
This revision is now accepted and ready to land.Dec 1 2022, 8:59 PM

I changed from DISTVERSION to PORTVERSION so that the package versioning matches the compiled-in version numbers. The porter's handbook doesn't seem to discourage this, just noting that 'Only one of PORTVERSION and DISTVERSION can be set at a time.'

If you feel strongly, I can revert this part and I will certainly switch back to DISTVERSION when I can use the upstream release direclty rather than some mid-release snapshot from the main branch.

This revision was automatically updated to reflect the committed changes.