Page MenuHomeFreeBSD
Differential D37506

devel/linux_libusb: disable date/time nonreproducible build warning
ClosedPublic
Actions

Authored by emaste on Nov 25 2022, 7:25 PM.
Tags
None
Referenced Files
F132975535: D37506.id113689.diff
Tue, Oct 21, 5:54 PM
F132975193: D37506.id113690.diff
Tue, Oct 21, 5:50 PM
F132974722: D37506.id.diff
Tue, Oct 21, 5:47 PM
F132974519: D37506.id113522.diff
Tue, Oct 21, 5:43 PM
Unknown Object (File)
Tue, Oct 21, 5:38 AM
Unknown Object (File)
Thu, Oct 16, 2:00 AM
Unknown Object (File)
Sat, Oct 11, 1:26 PM
Unknown Object (File)
Wed, Oct 1, 2:49 PM
View All Files
Subscribers
None

Details

Reviewers
• hselasky
jrm
Group Reviewers
Ports Committers
Commits
R11:c43b10698c7c: devel/linux_libusb: disable date/time nonreproducible build warning
Summary

The base system build infrastructure will add -Wdate-time, to avoid use of nonreproducible __DATE__ and __TIME__ in the base system.

This port makes use of a GCC that does not support -Wdate-time, so opt out of the warning.

PR: 267902 [exp-run]
Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Nov 25 2022, 7:25 PM
emaste created this revision.
emaste added inline comments.Nov 25 2022, 7:55 PM
devel/linux_libusb/Makefile
45

FWIW existing similar cases in the ports tree make use of both MAKE_ENV and MAKE_ARGS. Either works, but perhaps this should be MAKE_ARGS here for consistency with the NO_WERROR setting above.

• hselasky accepted this revision.Nov 26 2022, 8:30 AM

I'm good with whatever you find works this time.

This revision is now accepted and ready to land.Nov 26 2022, 8:30 AM
emaste added a reviewer: Ports Committers.Nov 30 2022, 6:22 PM

Add Ports Committers for src committer to ports tree approval

emaste updated this revision to Diff 113689.Nov 30 2022, 6:22 PM

Use MAKE_ARGS as discussed

This revision now requires review to proceed.Nov 30 2022, 6:22 PM
jrm accepted this revision as: jrm.Nov 30 2022, 6:28 PM
This revision is now accepted and ready to land.Nov 30 2022, 6:28 PM
Closed by commit R11:c43b10698c7c: devel/linux_libusb: disable date/time nonreproducible build warning (authored by emaste). · Explain WhyNov 30 2022, 6:57 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: R11:c43b10698c7c: devel/linux_libusb: disable date/time nonreproducible build warning.

Revision Contents
Changeset List

PathSize
devel/
linux_libusb/
1 line

Diff 113522

View Options

devel/linux_libusb/Makefile

Loading...