csh: install hard link with same mode as target
ClosedPublic
Actions

Authored by emaste on Nov 24 2022, 7:49 PM.

Details

Reviewers

Group Reviewers

Commits

rGc702ed6eb8d4: csh: install hard link with same mode as target
rG67d2aaf078e9: csh: install hard link with same mode as target

Summary

Previously when using NO_ROOT we recorded METALOG entries for the /.cshrc hard link with a different file mode than the link target, which is not permitted.

We cannot just set LINKMODE here as it would also apply to the hard link for the tcsh binary.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

This feels a bit hacky, but I don't think it's worth trying to add per-file LINKMODE support to address this one special case.

Add a comment explaining the slightly hackish use of explicit -m in the link creation.

emaste added a child revision: D37521: CI: Run pkgbase METALOG lint script.Nov 28 2022, 4:29 PM

LGTM

I do wonder if /.cshrc should survive the pkgbase transition.

This revision is now accepted and ready to land.Nov 29 2022, 6:21 PM

I do wonder if /.cshrc should survive the pkgbase transition.

Yes, I am not sure why we install /.cshrc and /.profile. Perhaps I will look at that in a bit.

Closed by commit rG67d2aaf078e9: csh: install hard link with same mode as target (authored by emaste). · Explain WhyNov 29 2022, 9:05 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG67d2aaf078e9: csh: install hard link with same mode as target.

Herald added a subscriber: imp. · View Herald TranscriptNov 29 2022, 9:05 PM

emaste added a commit: rGc702ed6eb8d4: csh: install hard link with same mode as target.Mar 23 2023, 3:10 PM

Revision Contents
Changeset List

Path

Size

bin/

csh/

Makefile

5 lines

Diff 113557

View Options

csh: install hard link with same mode as targetClosedPublicActions