Page MenuHomeFreeBSD

csh: install hard link with same mode as target
ClosedPublic

Authored by emaste on Thu, Nov 24, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 3, 1:30 AM
Unknown Object (File)
Tue, Nov 29, 9:04 PM
Unknown Object (File)
Tue, Nov 29, 9:04 PM
Subscribers

Details

Summary

Previously when using NO_ROOT we recorded METALOG entries for the /.cshrc hard link with a different file mode than the link target, which is not permitted.

We cannot just set LINKMODE here as it would also apply to the hard link for the tcsh binary.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

This feels a bit hacky, but I don't think it's worth trying to add per-file LINKMODE support to address this one special case.

Add a comment explaining the slightly hackish use of explicit -m in the link creation.

brooks added a subscriber: brooks.

LGTM

I do wonder if /.cshrc should survive the pkgbase transition.

This revision is now accepted and ready to land.Tue, Nov 29, 6:21 PM

I do wonder if /.cshrc should survive the pkgbase transition.

Yes, I am not sure why we install /.cshrc and /.profile. Perhaps I will look at that in a bit.