Fix PR/267884
ClosedPublic
Actions

Authored by cy on Nov 23 2022, 1:45 AM.

Details

Reviewers

emaste
philip

Group Reviewers

secteam

Commits

rG8d3c6e82cdca: heimdal: The version string must always contain a terminating NUL
rGe7dcb18d5108: heimdal: The version string must always contain a terminating NUL
rGd7e8666ffb99: heimdal: The version string must always contain a terminating NUL

Summary

heimdal: The version string must always contain a terminating NUL

Should the sender send a string without a terminating NUL, ensure that the NUL terminates the string regardless.

And while at it only process the version string when bytes are returned.

Test Plan

Fix tested locally.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cy created this revision.Nov 23 2022, 1:45 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 23 2022, 1:45 AM

cy requested review of this revision.Nov 23 2022, 1:45 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2022, 5:26 PM

Closed by commit rGd7e8666ffb99: heimdal: The version string must always contain a terminating NUL (authored by cy). · Explain Why

This revision was automatically updated to reflect the committed changes.

cy added a commit: rGd7e8666ffb99: heimdal: The version string must always contain a terminating NUL.

cy added a commit: rGe7dcb18d5108: heimdal: The version string must always contain a terminating NUL.Dec 1 2022, 2:25 PM

cy added a commit: rG8d3c6e82cdca: heimdal: The version string must always contain a terminating NUL.

Revision Contents
Changeset List

Path

Size

crypto/

heimdal/

lib/

krb5/

recvauth.c

26 lines

Diff 113502

View Options

crypto/heimdal/lib/krb5/recvauth.c

Fix PR/267884ClosedPublicActions