makefs: Ignore some sign comparison warnings from GCC.
ClosedPublic
Actions

Authored by jhb on Nov 22 2022, 11:12 PM.

Details

Reviewers

Commits

rGf31f677c1d41: makefs: Ignore some sign comparison warnings from GCC.
rGabb9a940bb48: makefs: Ignore some sign comparison warnings from GCC.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 22 2022, 11:12 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptNov 22 2022, 11:12 PM

jhb requested review of this revision.Nov 22 2022, 11:12 PM

Harbormaster completed remote builds in B48460: Diff 113421.Nov 22 2022, 11:12 PM

jhb added a parent revision: D37469: makefs zfs: Disable -Wunused-function for GCC as well..Nov 22 2022, 11:12 PM

The one in zap.c is easy to fix directly, but this is ok for now.

This revision is now accepted and ready to land.Nov 23 2022, 2:23 PM

In D37470#852052, @markj wrote:

The one in zap.c is easy to fix directly, but this is ok for now.

Well, I think fixing it "correctly" requires changes to upstream OpenZFS and that is why I punted.

Closed by commit rGabb9a940bb48: makefs: Ignore some sign comparison warnings from GCC. (authored by jhb). · Explain WhyNov 23 2022, 6:39 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGabb9a940bb48: makefs: Ignore some sign comparison warnings from GCC..

jhb added a commit: rGf31f677c1d41: makefs: Ignore some sign comparison warnings from GCC..Mar 22 2023, 4:33 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

makefs/

ffs/

Makefile.inc

2 lines

zfs/

Makefile.inc

1 line

Diff 113448

View Options

usr.sbin/makefs/ffs/Makefile.inc