Page MenuHomeFreeBSD
Differential D37447

freebsd-doc zh-tw font problem in pdf
ClosedPublic
Actions

Authored by yanhaowang on Nov 19 2022, 12:02 PM.
Tags
None
Referenced Files
F111870908: D37447.id114563.diff
Sun, Mar 9, 2:50 PM
Unknown Object (File)
Sun, Feb 23, 10:41 PM
Unknown Object (File)
Sat, Feb 22, 8:51 AM
Unknown Object (File)
Fri, Feb 14, 10:59 PM
Unknown Object (File)
Fri, Feb 14, 3:24 PM
Unknown Object (File)
Fri, Feb 14, 8:12 AM
Unknown Object (File)
Sat, Feb 8, 7:02 PM
Unknown Object (File)
Sat, Feb 8, 1:15 PM
View All Files
Subscribers
dbaio
lwhsu
rcyu
yklaxds_gmail.com
zlei

Details

Reviewers
carlavilla
dbaio
Summary

fix freebsd-Doc zh-tw pdf font problem

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 48431
Build 45317: arc lint + arc unit

Event Timeline

yanhaowang requested review of this revision.Nov 19 2022, 12:02 PM
yanhaowang created this revision.
Harbormaster completed remote builds in B48431: Diff 113344.Nov 19 2022, 12:02 PM
carlavilla added a reviewer: carlavilla.Nov 21 2022, 7:02 PM
lwhsu added a subscriber: lwhsu.Nov 22 2022, 5:24 AM

Is this suppressing D36623?

yklaxds_gmail.com added a subscriber: yklaxds_gmail.com.Nov 24 2022, 12:29 AM

Could you please add font support for zh-cn as well? Thank you.

dbaio added a subscriber: dbaio.Nov 24 2022, 1:09 AM
zlei added a subscriber: zlei.Nov 29 2022, 3:35 AM
dbaio requested changes to this revision.Dec 24 2022, 1:35 AM

Hi.

Thanks for working on this.

As we have a few things to fix in the ports/fonts, let's change a little bit here.

We need to determine if the fonts are installed, so let's check before building zh-tw PDFs.

Regards.

documentation/tools/asciidoctor.sh
73–74

Check if the zh-tw font exists; if it doesn't, print a message and return without running asciidoctor.

76

This could be default

This revision now requires changes to proceed.Dec 24 2022, 1:35 AM
yanhaowang updated this revision to Diff 114549.Dec 26 2022, 7:21 AM

check font file and add zh-cn theme file

Harbormaster completed remote builds in B48888: Diff 114549.Dec 26 2022, 7:21 AM
yanhaowang updated this revision to Diff 114563.Dec 27 2022, 2:06 AM

change font directory

Harbormaster completed remote builds in B48889: Diff 114563.Dec 27 2022, 2:06 AM
rcyu added a subscriber: rcyu.Dec 29 2022, 4:56 AM
dbaio added a comment.EditedJan 20 2023, 6:26 PM

Hello.

You don't need to update this review anymore.
I have it working now, with slight changes.

How can I register your contribution,
<bses30074@gmail.com>

?

Thanks for your work.

dbaio mentioned this in R9:6a430fe152e6: documentation/pdf: Improve zh-cn|zh-tw font issues.Jan 21 2023, 12:21 AM
dbaio accepted this revision.Jan 21 2023, 12:26 AM

trying to close it, needs be 'accepted'

This revision is now accepted and ready to land.Jan 21 2023, 12:26 AM
dbaio closed this revision.Jan 21 2023, 12:26 AM

Revision Contents
Changeset List

PathSize
documentation/
tools/
10 lines
shared/
zh-tw/
17 lines

Diff 113344

View Options

documentation/tools/asciidoctor.sh

Loading...
View Options

shared/zh-tw/zh-tw-theme.yml

Loading...