devel/ksh93: remove sbrk() use

[brooks]

Summary

ksh supports multiple sources of heap memory. Completely disable the
use of sbrk() as a memory source in favor of mmap(). This allows
compilation on aarch64 (and presumably riscv64).

[brooks]

I've tested this as far as running the built ksh trivially and aarch64. Unfortunately make test blew up with a mktemp usage error that I've not dug into yet.

[diizzy]

@cy
Perhaps time to switch repo to https://github.com/ksh93/ksh
@brooks Submit it upstream if applicable?

[brooks]

In D37312#847847, @diizzy wrote:

@brooks Submit it upstream if applicable?

This patch isn't suitable for upstream, but I can certainly look at doing that eventually. For now this unblocked testing zfs on aarch64.

[cy]

In D37312#847921, @brooks wrote:

In D37312#847847, @diizzy wrote:

@brooks Submit it upstream if applicable?

This patch isn't suitable for upstream, but I can certainly look at doing that eventually. For now this unblocked testing zfs on aarch64.

There is no need to switch because we already have ports that based on https://github.com/ksh93/ksh in shells/ksh and shells/ksh-devel. shells/ksh93 is the legacy version with all its undocumented but assumed bugs and warts for people who still need the legacy version. People are encouraged to use shells/ksh and shells/ksh-devel.

Go ahead and commit this change and don't forget to bump PORTREVISION. And don't consider basing this port on GH ksh93/ksh. We already have two ports based on that project.

[diizzy]

Ahh, I managed to missed that looking at shells. Thanks for the clarification!