Page MenuHomeFreeBSD

pciconf(8): Decode ACS extended capability.
ClosedPublic

Authored by np on Nov 4 2022, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 10:11 AM
Unknown Object (File)
Mar 12 2024, 4:19 AM
Unknown Object (File)
Mar 12 2024, 4:19 AM
Unknown Object (File)
Mar 12 2024, 4:19 AM
Unknown Object (File)
Mar 12 2024, 4:19 AM
Unknown Object (File)
Mar 8 2024, 4:55 AM
Unknown Object (File)
Jan 4 2024, 7:24 PM
Unknown Object (File)
Jan 4 2024, 7:24 PM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np requested review of this revision.Nov 4 2022, 8:11 PM

Here are a couple of examples from the motherboard that i tested it on, with the available caps disabled and enabled.

# pciconf -lc pcib4
pcib4@pci0:0:3:0:	class=0x060400 rev=0x02 hdr=0x01 vendor=0x8086 device=0x2f08 subvendor=0x8086 subdevice=0x0000
...
    ecap 000d[110] = ACS 1 Source Validation disabled, Translation Blocking disabled
                     P2P Req Redirect disabled, P2P Cmpl Redirect disabled
                     P2P Upstream Forwarding disabled, P2P Egress Control unavailable
                     P2P Direct Translated unavailable, Enhanced Capability unavailable


# pciconf -lc pcib4
pcib4@pci0:0:3:0:	class=0x060400 rev=0x02 hdr=0x01 vendor=0x8086 device=0x2f08 subvendor=0x8086 subdevice=0x0000
...
    ecap 000d[110] = ACS 1 Source Validation enabled, Translation Blocking enabled
                     P2P Req Redirect enabled, P2P Cmpl Redirect enabled
                     P2P Upstream Forwarding enabled, P2P Egress Control unavailable
                     P2P Direct Translated unavailable, Enhanced Capability unavailable

}
kib added inline comments.
usr.sbin/pciconf/cap.c
1033

static const char *const acc[] ?

1036

So should we check that the version is known?

This revision is now accepted and ready to land.Nov 5 2022, 12:04 AM

Incorporate feedback from kib.

This revision now requires review to proceed.Nov 7 2022, 6:49 PM
np marked 2 inline comments as done.Nov 7 2022, 6:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2022, 9:21 PM
This revision was automatically updated to reflect the committed changes.