Remove an unneeded cpu_dcache_wb_range from arm64
ClosedPublic
Actions

Authored by andrew on Oct 18 2022, 4:46 PM.

Details

Reviewers

manu
imp

Group Reviewers

arm64

Commits

rG7ddba690f8ae: Remove an unneeded cpu_dcache_wb_range from arm64

Summary

The cpu_dcache_wb_range function is an expensive function that is
unneeded in ddb. It is used when the cache needs to be written to RAM,
e.g. when working with a non-cache coherent device.

Remove it as cpu_icache_sync_range already has the needed d-cache
handling to ensure any changed memory is visible to the i-cache.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Oct 18 2022, 4:46 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 18 2022, 4:46 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Oct 18 2022, 4:46 PM

Harbormaster completed remote builds in B47879: Diff 111932.Oct 18 2022, 4:47 PM

imp accepted this revision.Oct 19 2022, 5:34 PM

This revision is now accepted and ready to land.Oct 19 2022, 5:34 PM

Closed by commit rG7ddba690f8ae: Remove an unneeded cpu_dcache_wb_range from arm64 (authored by andrew). · Explain WhyOct 27 2022, 4:11 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG7ddba690f8ae: Remove an unneeded cpu_dcache_wb_range from arm64.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

db_interface.c

6 lines

Diff 112289

View Options

sys/arm64/arm64/db_interface.c

Remove an unneeded cpu_dcache_wb_range from arm64ClosedPublicActions