Page MenuHomeFreeBSD

Eliminate nd6_nud_hint() and its TCP bindings.
ClosedPublic

Authored by melifaro on Sep 20 2015, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 5:25 PM
Unknown Object (File)
Sun, Nov 17, 4:12 AM
Unknown Object (File)
Thu, Nov 7, 9:00 PM
Unknown Object (File)
Wed, Nov 6, 7:43 AM
Unknown Object (File)
Oct 18 2024, 1:02 AM
Unknown Object (File)
Oct 10 2024, 11:29 AM
Unknown Object (File)
Oct 2 2024, 3:19 AM
Unknown Object (File)
Sep 30 2024, 4:24 AM
Subscribers

Details

Summary

Initially function was introduced in r53541 (KAME initial commit) to "provide hints from upper layer protocols that indicate a connection is making "forward progress"" (quote from RFC 2461 7.3.1 Reachability Confirmation).
However, it was converted to do nothing (e.g. just return) in r122922 (tcp_hostcache implementation) back in 2003. Some defines were moved to tcp_var.h in r169541. Then, it was broken (for non-corner cases) by r186119 (L2<>L3 split) in 2008 (NULL ifp in nd6_lookup). So, right now this code is broken and has no "real" base users.

Even if ability to provide reachability hint from upper-layer protocol like TCP might sound as a good idea, it is not trivial to do efficient implementation. Personally I don't think it is needed ATM - if one really needs to reduce number of ND confirmations, "basereachable" variable can be increased to sufficient value. Given that, I'd like to remove the part of code in question.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro retitled this revision from to Eliminate nd6_nud_hint() and its TCP bindings..
melifaro updated this object.
melifaro edited the test plan for this revision. (Show Details)
melifaro added a reviewer: network.
hrs added a reviewer: hrs.
This revision is now accepted and ready to land.Sep 20 2015, 5:45 PM
gnn added a reviewer: gnn.
melifaro edited edge metadata.

Do pre-commit sync.

This revision now requires review to proceed.Sep 27 2015, 5:12 AM
melifaro edited edge metadata.

Remove non-relevant __noinline definitions.

This revision was automatically updated to reflect the committed changes.