Revert "Avoid using TARGET_ARCH in llvm.build.mk"
ClosedPublic
Actions

Authored by kevans on Oct 13 2022, 8:07 PM.

Details

Reviewers

imp
dim
jrtc27

Commits

rGe2f3e8c5e89c: Revert "Avoid using TARGET_ARCH in llvm.build.mk"
rG63d9ad6e46d2: Revert "Avoid using TARGET_ARCH in llvm.build.mk"
rGed7910fbac07: Revert "Avoid using TARGET_ARCH in llvm.build.mk"

Summary

This reverts commit 8534e6be8110a8126268a38dc0557a2d15615ce9, and adds
a cautionary note that there are dragons about that should be considered
when changing it.

PR: 267026

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans requested review of this revision.Oct 13 2022, 8:07 PM

kevans created this revision.

Harbormaster completed remote builds in B47836: Diff 111773.Oct 13 2022, 8:08 PM

imp accepted this revision.Oct 13 2022, 8:09 PM

This revision is now accepted and ready to land.Oct 13 2022, 8:09 PM

Thanks for the comment. Generally we want to avoid TARGET_ARCH, but this case is definitely special, and the comment explains why nicely.

mandree added a subscriber: mandree.Oct 13 2022, 8:14 PM

LGTM

Closed by commit rGed7910fbac07: Revert "Avoid using TARGET_ARCH in llvm.build.mk" (authored by kevans). · Explain WhyOct 14 2022, 3:05 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGed7910fbac07: Revert "Avoid using TARGET_ARCH in llvm.build.mk".

kevans added a commit: rG63d9ad6e46d2: Revert "Avoid using TARGET_ARCH in llvm.build.mk".Oct 17 2022, 3:42 PM

kevans added a commit: rGe2f3e8c5e89c: Revert "Avoid using TARGET_ARCH in llvm.build.mk".

Revision Contents
Changeset List

Path

Size

lib/

clang/

llvm.build.mk

11 lines

Diff 111778

View Options

Revert "Avoid using TARGET_ARCH in llvm.build.mk"ClosedPublicActions