diff: Don't treat null characters like carriage returns in readhash().
ClosedPublic
Actions

Authored by jhb on Sep 29 2022, 10:26 PM.

Details

Reviewers

pstef
thj
bapt

Commits

rG95a52eb29ca9: diff: Don't treat null characters like carriage returns in readhash().
rG4e0771714d61: diff: Don't treat null characters like carriage returns in readhash().

Summary

The implicit fall-through in the !D_FORCEASCII case caused null
characters to be treated as carriage returns honoring the D_STRIPCR,
D_FOLDBLANKS, and D_IGNOREBLANKS flags.

Reported by: GCC -Wimplicit-fallthrough
Fixes: 3cbf98e2bee9 diff: read whole files to determine if they are ASCII text

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 29 2022, 10:26 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2022, 10:26 PM

jhb requested review of this revision.Sep 29 2022, 10:26 PM

Harbormaster completed remote builds in B47627: Diff 111230.Sep 29 2022, 10:26 PM

bapt accepted this revision.Oct 12 2022, 3:26 PM

This revision is now accepted and ready to land.Oct 12 2022, 3:26 PM

Closed by commit rG4e0771714d61: diff: Don't treat null characters like carriage returns in readhash(). (authored by jhb). · Explain WhyNov 16 2022, 3:23 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG4e0771714d61: diff: Don't treat null characters like carriage returns in readhash()..

jhb added a commit: rG95a52eb29ca9: diff: Don't treat null characters like carriage returns in readhash()..Jan 24 2023, 5:43 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffreg.c

2 lines

Diff 113168

View Options

diff: Don't treat null characters like carriage returns in readhash().ClosedPublicActions