Page MenuHomeFreeBSD

diff: Don't treat null characters like carriage returns in readhash().
ClosedPublic

Authored by jhb on Sep 29 2022, 10:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 9:06 AM
Unknown Object (File)
Sat, Oct 11, 9:06 AM
Unknown Object (File)
Sat, Oct 11, 9:06 AM
Unknown Object (File)
Sat, Oct 11, 1:35 AM
Unknown Object (File)
Sep 2 2025, 5:24 PM
Unknown Object (File)
Aug 25 2025, 9:40 PM
Unknown Object (File)
Aug 25 2025, 8:52 PM
Unknown Object (File)
Aug 24 2025, 1:21 PM
Subscribers

Details

Summary

The implicit fall-through in the !D_FORCEASCII case caused null
characters to be treated as carriage returns honoring the D_STRIPCR,
D_FOLDBLANKS, and D_IGNOREBLANKS flags.

Reported by: GCC -Wimplicit-fallthrough
Fixes: 3cbf98e2bee9 diff: read whole files to determine if they are ASCII text

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable