Add more stats to gnop(8).

[trasz]

Summary

gnop(8) already stores up and shows stats for the number of BIO_READ
and BIO_WRITE calls that pass through it. Counting the other types
as well makes it more useful for testing other stuff.

PR: kern/198405
Submitted by: Matthew D. Fuller <fullermd at over-yonder dot net>

[mav]

I have no objections, but think it could look better if made an array.

[trasz]

Ok, so, the problem with making it an array is that bio_cmd flags are defined like this:

#define BIO_READ 0x01 /* Read I/O data */
#define BIO_WRITE 0x02 /* Write I/O data */
#define BIO_DELETE 0x04 /* TRIM or free blocks, i.e. mark as unused */
#define BIO_GETATTR 0x08 /* Get GEOM attributes of object */
#define BIO_FLUSH 0x10 /* Commit outstanding I/O now */
#define BIO_CMD0 0x20 /* Available for local hacks */
#define BIO_CMD1 0x40 /* Available for local hacks */
#define BIO_CMD2 0x80 /* Available for local hacks */

Ie, it's not an enum, so we can't just do "sc->sc_cmds[bp->bio_cmd]++". And without it, making it an array doesn't really improve much.

[wblock]

sbin/geom/class/nop/gnop.8

75 ↗

(On Diff #8784)

It also gathers statistics on the number of read, write, delete,

76 ↗

(On Diff #8784)

getattr, flush, and other requests, and the number of bytes read and written.

77 ↗

(On Diff #8784)

.Nm
can also be used as a good starting point for implementing new GEOM