Page MenuHomeFreeBSD
Differential D36781

linux32: binutils as requires %eflags instead of %flags for CFI.
ClosedPublic
Actions

Authored by jhb on Sep 28 2022, 9:40 PM.
Tags
None
Referenced Files
F152991315: D36781.id111161.diff
Sat, Apr 18, 12:32 PM
Unknown Object (File)
Sat, Apr 18, 4:09 AM
Unknown Object (File)
Fri, Apr 17, 9:16 PM
Unknown Object (File)
Thu, Apr 16, 2:19 AM
Unknown Object (File)
Thu, Apr 9, 8:58 PM
Unknown Object (File)
Sat, Mar 28, 5:19 AM
Unknown Object (File)
Wed, Mar 25, 5:45 AM
Unknown Object (File)
Sun, Mar 22, 7:48 AM
View All 91 Files
Subscribers
dim
imp

Details

Reviewers
kib
Commits
rG20125b23ff15: linux32: binutils as requires %eflags instead of %flags for CFI.
rGa35572b16e38: linux32: binutils as requires %eflags instead of %flags for CFI.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Sep 28 2022, 9:40 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 28 2022, 9:40 PM
jhb requested review of this revision.Sep 28 2022, 9:40 PM
Harbormaster completed remote builds in B47593: Diff 111161.Sep 28 2022, 9:40 PM
kib accepted this revision.Sep 28 2022, 9:42 PM

Does clang work with %eflags?

This revision is now accepted and ready to land.Sep 28 2022, 9:42 PM
jhb added a comment.Sep 28 2022, 9:43 PM
In D36781#834878, @kib wrote:

Does clang work with %eflags?

No. :( (I tried). Arguably %eflags is more correct, and possibly it should be reported as a bug to LLVM upstream to use the eflags/rflags names.

jhb added a subscriber: dim.Sep 28 2022, 9:43 PM

(Adding dim@ in case he wants to report an upstream bug about supporting %eflags upstream)

Closed by commit rGa35572b16e38: linux32: binutils as requires %eflags instead of %flags for CFI. (authored by jhb). · Explain WhySep 29 2022, 10:08 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGa35572b16e38: linux32: binutils as requires %eflags instead of %flags for CFI..
jhb added a commit: rG20125b23ff15: linux32: binutils as requires %eflags instead of %flags for CFI..Nov 11 2022, 6:38 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
linux32/
8 lines

Diff 111220

View Options

sys/amd64/linux32/linux32_locore.asm

Loading...