Page MenuHomeFreeBSD
Differential D36715

vt(4): Make sure vt_switch_timer() has a sleepable context
ClosedPublic
Actions

Authored by • hselasky on Sep 26 2022, 3:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 13, 1:48 AM
Unknown Object (File)
Wed, May 13, 1:48 AM
Unknown Object (File)
Mon, May 4, 4:02 PM
Unknown Object (File)
Thu, Apr 30, 7:33 AM
Unknown Object (File)
Tue, Apr 28, 3:48 PM
Unknown Object (File)
Tue, Apr 28, 3:13 AM
Unknown Object (File)
Thu, Apr 23, 8:04 AM
Unknown Object (File)
Wed, Apr 22, 12:16 PM
View All Files
Subscribers
avg
imp

Details

Reviewers
manu
bz
imp
Commits
rG1bac84980682: vt(4): Make sure vt_switch_timer() has a sleepable context.
rG2cce9aa0785c: vt(4): Make sure vt_switch_timer() has a sleepable context.
Summary

Fixes the following panic backtrace:

panic()
usbhid_sync_xfer()
usbhid_set_report()
hid_set_report()
hidbus_write()
hid_write()
hkbd_set_leds()
hkbd_ioctl_locked()
hkbd_ioctl_locked()
hkbd_ioctl()
kbdmux_ioctl()
vt_window_switch()
vt_switch_timer()

MFC after: 1 week
Sponsored by: NVIDIA Networking

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• hselasky created this revision.Sep 26 2022, 3:12 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 26 2022, 3:12 PM
• hselasky requested review of this revision.Sep 26 2022, 3:12 PM
• hselasky updated this revision to Diff 110996.Sep 26 2022, 3:16 PM
• hselasky edited the summary of this revision. (Show Details)

Whitespace fixes.

• hselasky updated this revision to Diff 110997.Sep 26 2022, 3:23 PM

Fix compilation and some whitespace.

manu accepted this revision.Sep 26 2022, 3:36 PM
manu added a subscriber: avg.

If that solves @avg's problem I'm ok with the switch to taskqueue. (Not tested though).

This revision is now accepted and ready to land.Sep 26 2022, 3:36 PM
imp accepted this revision.Sep 26 2022, 3:57 PM

seems reasonable on the surface

Closed by commit rG2cce9aa0785c: vt(4): Make sure vt_switch_timer() has a sleepable context. (authored by • hselasky). · Explain WhySep 27 2022, 2:08 PM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG2cce9aa0785c: vt(4): Make sure vt_switch_timer() has a sleepable context..
• hselasky added a commit: rG1bac84980682: vt(4): Make sure vt_switch_timer() has a sleepable context..Oct 4 2022, 2:51 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
3 lines
13 lines
1 line

Diff 111072

View Options

sys/dev/vt/vt.h

Loading...
View Options

sys/dev/vt/vt_core.c

Loading...
View Options

sys/dev/vt/vt_cpulogos.c

Loading...