Page MenuHomeFreeBSD
Differential D36560

release/rc.local: Provide option to shutdown after installation complete
ClosedPublic
Actions

Authored by woodsb02 on Sep 14 2022, 1:22 PM.
Tags
None
Referenced Files
F83046300: D36560.diff
Sun, May 5, 12:44 PM
F82989588: D36560.id110684.diff
Sat, May 4, 9:29 PM
Unknown Object (File)
Mar 14 2024, 12:45 PM
Unknown Object (File)
Mar 11 2024, 2:04 AM
Unknown Object (File)
Mar 11 2024, 2:04 AM
Unknown Object (File)
Mar 11 2024, 12:49 AM
Unknown Object (File)
Feb 23 2024, 11:14 PM
Unknown Object (File)
Jan 5 2024, 6:36 AM
View All 39 Files
Subscribers
imp

Details

Reviewers
philip
nwhitehorn
brd
Commits
rGe4505364c087: release/rc.local: Provide option to shutdown after installation complete
Summary

release/rc.local: Provide option to shutdown after installation complete

This can be useful instead of reboot if installing in a virtual machine,
and the user wants to modify the VM hardware or virtual media mounts
prior to booting into the newly installed system.

Reported by: Juan Manuel Palacios (@jmp_imaginarium on Twitter)
Approved by: <SRC COMMITTER APPROVAL REQUIRED>

Test Plan

Build release ISO, boot it in test VM, complete install, at the end test the 3 options for restart, shutdown, live cd

Confirmed working - refer to screenshot below

I've also tested other failure modes - choosing shell or livecd (instead of install) immediately upon booting the ISO, and also cancelling the install part way through in multiple ways (confirmed it recovers to the first install screen as per usual).

complete-menu.png (626×1 px, 22 KB)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47375
Build 44262: arc lint + arc unit

Event Timeline

woodsb02 created this revision.Sep 14 2022, 1:22 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 14 2022, 1:22 PM
woodsb02 requested review of this revision.Sep 14 2022, 1:22 PM
Harbormaster completed remote builds in B47375: Diff 110544.Sep 14 2022, 1:22 PM
woodsb02 edited the summary of this revision. (Show Details)Sep 14 2022, 1:23 PM
woodsb02 edited the test plan for this revision. (Show Details)Sep 15 2022, 6:29 AM
woodsb02 edited the test plan for this revision. (Show Details)Sep 15 2022, 6:40 AM
philip accepted this revision.Sep 16 2022, 5:34 AM

This looks good! And very useful.

Reviewed by: philip

This revision is now accepted and ready to land.Sep 16 2022, 5:34 AM
woodsb02 added a comment.Sep 16 2022, 8:35 AM

Thanks - you happy for me to put approved by: philip (your src commit approval)?

philip added a comment.Sep 16 2022, 9:35 AM

Absolutely. Go for it. :-)

Closed by commit rGe4505364c087: release/rc.local: Provide option to shutdown after installation complete (authored by woodsb02). · Explain WhySep 17 2022, 12:08 AM
This revision was automatically updated to reflect the committed changes.
woodsb02 added a commit: rGe4505364c087: release/rc.local: Provide option to shutdown after installation complete.

Revision Contents
Changeset List

PathSize
release/
14 lines

Diff 110544

View Options

release/rc.local

Loading...