Page MenuHomeFreeBSD

veriexec: fixed usage and getopt issue on armv6
ClosedPublic

Authored by sebastien.bini_stormshield.eu on Sep 7 2022, 8:06 AM.
Tags
None
Referenced Files
F150434480: D36477.id110253.diff
Wed, Apr 1, 5:07 AM
Unknown Object (File)
Sun, Mar 15, 2:39 AM
Unknown Object (File)
Tue, Mar 10, 2:15 PM
Unknown Object (File)
Tue, Mar 10, 8:24 AM
Unknown Object (File)
Feb 24 2026, 10:26 PM
Unknown Object (File)
Feb 23 2026, 6:02 PM
Unknown Object (File)
Feb 23 2026, 6:02 PM
Unknown Object (File)
Feb 21 2026, 11:16 PM
Subscribers

Details

Reviewers
wma
mw
imp
Summary

This fixes an issue introduced by https://reviews.freebsd.org/D33246

getopt returns an int, which was stored inside c of type char. c was then compared to -1. All those type conversions worked fine on our amd64 systems, but not on armv6 architecture.

The -1 returned by getopt, stored in c, never successfully compared to -1, causing the program to fall into the usage error in the default: switch case.

I also fixed the usage function, as -C takes a path as parameter.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47276
Build 44163: arc lint + arc unit