Page MenuHomeFreeBSD

veriexec: fixed usage and getopt issue on armv6
ClosedPublic

Authored by sebastien.bini_stormshield.eu on Sep 7 2022, 8:06 AM.
Tags
None
Referenced Files
F120039485: D36477.id110253.diff
Sat, Jun 14, 11:58 AM
Unknown Object (File)
Tue, Jun 10, 9:27 PM
Unknown Object (File)
Mon, Jun 9, 3:28 AM
Unknown Object (File)
Mar 16 2025, 2:01 PM
Unknown Object (File)
Feb 24 2025, 8:43 PM
Unknown Object (File)
Feb 13 2025, 5:36 PM
Unknown Object (File)
Feb 10 2025, 9:45 PM
Unknown Object (File)
Jan 17 2025, 9:39 PM
Subscribers

Details

Reviewers
wma
mw
imp
Summary

This fixes an issue introduced by https://reviews.freebsd.org/D33246

getopt returns an int, which was stored inside c of type char. c was then compared to -1. All those type conversions worked fine on our amd64 systems, but not on armv6 architecture.

The -1 returned by getopt, stored in c, never successfully compared to -1, causing the program to fall into the usage error in the default: switch case.

I also fixed the usage function, as -C takes a path as parameter.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47276
Build 44163: arc lint + arc unit