Page MenuHomeFreeBSD

veriexec: fixed usage and getopt issue on armv6
ClosedPublic

Authored by sebastien.bini_stormshield.eu on Sep 7 2022, 8:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 15, 5:06 PM
Unknown Object (File)
Thu, Jan 15, 5:45 AM
Unknown Object (File)
Tue, Jan 13, 3:43 AM
Unknown Object (File)
Thu, Jan 8, 8:11 AM
Unknown Object (File)
Mon, Jan 5, 8:41 PM
Unknown Object (File)
Mon, Dec 29, 10:05 PM
Unknown Object (File)
Sun, Dec 21, 11:33 PM
Unknown Object (File)
Dec 14 2025, 5:50 AM
Subscribers

Details

Reviewers
wma
mw
imp
Summary

This fixes an issue introduced by https://reviews.freebsd.org/D33246

getopt returns an int, which was stored inside c of type char. c was then compared to -1. All those type conversions worked fine on our amd64 systems, but not on armv6 architecture.

The -1 returned by getopt, stored in c, never successfully compared to -1, causing the program to fall into the usage error in the default: switch case.

I also fixed the usage function, as -C takes a path as parameter.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47276
Build 44163: arc lint + arc unit