libc/stdio: only rollback FILE state back on EINTR
ClosedPublic
Actions

Authored by kib on Sep 2 2022, 2:03 PM.

Details

Reviewers

markj
emaste

Commits

rG44cf1e5eb470: libc/stdio: only roll FILE state back on EINTR
rG120bacabfd4f: __swbuf(): style

Summary

Reported by:    JunT <takimoto-j@kba.biglobe.ne.jp>
PR:     266171

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sep 2 2022, 2:03 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 2 2022, 2:03 PM

kib requested review of this revision.Sep 2 2022, 2:03 PM

emaste accepted this revision.Sep 2 2022, 2:10 PM

This revision is now accepted and ready to land.Sep 2 2022, 2:10 PM

What about the handling of fflush() errors in __sfvwrite()?

In D36427#827331, @markj wrote:

What about the handling of fflush() errors in __sfvwrite()?

I thought that internal handling in __fflush() would be enough, but you are right, the bafaa70b6f9098d83d0 needs the similar adjustment.

Apply the EINTR check for __sfvwrite() as well

This revision now requires review to proceed.Sep 2 2022, 2:23 PM

markj accepted this revision.Sep 2 2022, 3:12 PM

This revision is now accepted and ready to land.Sep 2 2022, 3:12 PM

Closed by commit rG120bacabfd4f: __swbuf(): style (authored by kib). · Explain WhySep 3 2022, 1:19 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG120bacabfd4f: __swbuf(): style.

kib added a commit: rG44cf1e5eb470: libc/stdio: only roll FILE state back on EINTR.

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdio/

wbuf.c

4 lines

Diff 110094

View Options

libc/stdio: only rollback FILE state back on EINTRClosedPublicActions