Page MenuHomeFreeBSD

net80211: simplify an #ifdef INET/INET6 block
ClosedPublic

Authored by bz on Aug 31 2022, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 8:25 AM
Unknown Object (File)
Sat, Sep 27, 1:06 AM
Unknown Object (File)
Fri, Sep 26, 7:33 AM
Unknown Object (File)
Thu, Sep 18, 9:35 PM
Unknown Object (File)
Sep 10 2025, 11:56 PM
Unknown Object (File)
Sep 5 2025, 7:34 AM
Unknown Object (File)
Aug 23 2025, 10:23 PM
Unknown Object (File)
Aug 14 2025, 5:21 AM

Details

Summary

I got lost in the #ifdef #endif here so I checked the code to a
switch block with two non-overlapping #ifdef parts and a default
which makes it a lot easier to read.

No functional changes.

Sponsored by: The FreeBSD Foundation
MFC after: 5 days

Test Plan

I would highly appreciate if people would carefully
double-check that I manually change-ifdefed it correctly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Aug 31 2022, 10:39 PM
zlei added inline comments.
sys/net80211/ieee80211_output.c
1289–1291

Missing break here.

1307

ditto

Add missing breaks. Thank you for care fully checking! :)

bz marked 2 inline comments as done.Sep 2 2022, 1:57 AM
This revision is now accepted and ready to land.Sep 2 2022, 3:58 AM
This revision was automatically updated to reflect the committed changes.