rum(4): add support for hardware encryption (WEP, TKIP and CCMP)

[avos]

Summary

This diff includes:

• Transmitter Addresses, Keys and TKIP MIC addition to the Security Key Table.
• Proper SEC Control Registers initialization and maintenance.
• Additional flags and values in TX descriptor, which are required for encryption support.
• Error checking in RX path.

Test Plan

Tested on WUSB54GC, STA (WEP, TKIP, CCMP), HOSTAP (CCMP) and IBSS (CCMP, WPA-None) modes.

[avos]

Use key index instead of node id + fix bitmap cleanup.

[avos]

Fix build with USB_DEBUG.

[adrian]

hm, so I thought net80211 had a "do this deferred" but it only has taskqueues, not a callback queue for deferred things like this.

I'm okay with hand-crafted ones for now, but we should think about how to push it into the net80211 taskqueue - likely with an actual deferred callback framework there.

Ok, this looks fine. I have an 11bg rum device (RT2573) that I can test with; so once I get through the other commits I'll take a look at this one.

sys/dev/usb/wlan/if_rum.c

1269 ↗

(On Diff #8852)

0 * 4? Why's that?

[avos]

• De-hardcode max number of shared keys (RT2573_SKEY_MAX).
• Set key index for pairwise keys to 0 when h/w encryption is disabled.

[avos]

Rebase.

[avos]

In D3640#78035, @adrian wrote:

I'm okay with hand-crafted ones for now, but we should think about how to push it into the net80211 taskqueue - likely with an actual deferred callback framework there.

There is only one problem:
ieee80211_node_delucastkey(struct ieee80211_node *ni)
{
...

isowned = IEEE80211_NODE_IS_LOCKED(nt);
if (!isowned)
        IEEE80211_NODE_LOCK(nt);

...

status = ieee80211_crypto_delkey(ni->ni_vap, &ni->ni_ucastkey);

...

if (!isowned)
         IEEE80211_NODE_UNLOCK(nt);

After removing locks around ieee80211_crypto_delkey() any problems with iv_key_set() / iv_key_delete() LORs / sleepable calls should go away.