Differential D3605

rum(4): some non-functional changes / cleanup
ClosedPublic
Actions

Authored by avos on Sep 8 2015, 11:17 PM.

Details

Reviewers

adrian

Group Reviewers

Contributor Reviewers (ports)

Commits

rS288531: rum(4): some non-functional changes / cleanup

Summary

Remove unused sc_txtap_len/sc_rxtap_len fields.
Remove unused ackrate variable.
Remove unneded warning in rum_update_mcast().
Use nitems().
Replace some hardcoded values for RT2573_MAC_CSR1 register.
Remove second argument for RUM_LOCK_ASSERT() - it is always the same.

Test Plan

Tested with WUSB54GC, STA mode.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avos updated this revision to Diff 8605.Sep 8 2015, 11:17 PM

avos retitled this revision from to rum(4): some non-functional changes / cleanup.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptSep 8 2015, 11:17 PM

Herald added a subscriber: imp. · View Herald Transcript

avos added a child revision: D3629: rum(4): add command queue for running sleepable tasks in non-sleepable contexts.Oct 3 2015, 3:00 AM

avos added a reviewer: adrian.Oct 3 2015, 3:06 AM

Closed by commit rS288531: rum(4): some non-functional changes / cleanup (authored by adrian). · Explain WhyOct 3 2015, 5:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

wlan/

if_rum.c

41 lines

if_rumvar.h

7 lines

Diff 9080

View Options

head/sys/dev/usb/wlan/if_rum.c