Page MenuHomeFreeBSD

stand: Search less agressively for UFS super block
ClosedPublic

Authored by imp on Aug 18 2022, 3:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 5:48 PM
Unknown Object (File)
Wed, Dec 11, 10:47 PM
Unknown Object (File)
Sat, Dec 7, 9:04 AM
Unknown Object (File)
Nov 23 2024, 12:12 AM
Unknown Object (File)
Nov 8 2024, 11:22 AM
Unknown Object (File)
Nov 7 2024, 5:06 PM
Unknown Object (File)
Nov 7 2024, 10:11 AM
Unknown Object (File)
Nov 7 2024, 7:22 AM

Details

Summary

The boot loader should look in the standard places for the UFS
superblock, but not go too far into the speculative realm. Supress
errors about hash being invalid, which will allow us to boot, even when
the superblock looks good, but fails the hash test. This defers any
policy decisions about booting and/or recovery to userland. As a side
effect, we no longer spam the console with a lot of useless messages
about not being able to find UFS superblocks on devices that do not
contain a UFS filesystem.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Aug 18 2022, 3:59 AM
imp added a reviewer: mckusick.

This gets us back to close to what we had previously. You might want to reduce output further by adding the UFS_NOMSG flag, but generally non-UFS systems will not have a valid magic number which will prevent any further messages, so you should only get messages if you have something that is likely to be a UFS filesystem.

This revision is now accepted and ready to land.Aug 18 2022, 6:07 AM

I can confirm the console spam for non-UFS, ZFS, installations on bare metal (amd64) is gone.

This gets us back to close to what we had previously. You might want to reduce output further by adding the UFS_NOMSG flag, but generally non-UFS systems will not have a valid magic number which will prevent any further messages, so you should only get messages if you have something that is likely to be a UFS filesystem.

My plan was to do this and see how many reports of extra output we get that's not helpful.