Page MenuHomeFreeBSD
Differential D36221

pkgbase: Put nvmecontrol in its own package
ClosedPublic
Actions

Authored by manu on Aug 16 2022, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 7:57 AM
Unknown Object (File)
Fri, Jun 7, 6:48 AM
Unknown Object (File)
Mar 8 2024, 12:02 PM
Unknown Object (File)
Mar 8 2024, 6:56 AM
Unknown Object (File)
Mar 8 2024, 6:55 AM
Unknown Object (File)
Mar 8 2024, 6:51 AM
Unknown Object (File)
Mar 8 2024, 3:46 AM
Unknown Object (File)
Jan 3 2024, 6:39 PM
View All 39 Files
Subscribers
dab
emaste
imp

Details

Reviewers
emaste
Group Reviewers
pkgbase
Commits
rGb80ee728d2c4: pkgbase: Put nvmecontrol in its own package
rG5f9db65d8af0: pkgbase: Put nvmecontrol in its own package
Summary

It doesn't really make sense to have it in runtime and let's not
bloat utilities more.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Aug 16 2022, 7:22 PM
Herald added subscribers: dab, imp. · View Herald TranscriptAug 16 2022, 7:22 PM
manu requested review of this revision.Aug 16 2022, 7:22 PM
Harbormaster completed remote builds in B46963: Diff 109402.Aug 16 2022, 7:22 PM
manu added a reviewer: pkgbase.Aug 16 2022, 7:29 PM
emaste added a subscriber: emaste.Aug 16 2022, 7:35 PM
emaste added inline comments.
release/packages/Makefile.package
92

should this be just "nvme" perhaps? we might have other NVME utils in the future that should go in the same package?
@imp?

manu added inline comments.Aug 16 2022, 8:34 PM
release/packages/Makefile.package
92

nvme-tools perhaps ? (we already have some -tools package).

imp added inline comments.Aug 16 2022, 9:12 PM
release/packages/Makefile.package
92

I'm agnostic. There may be a need for other nvme related things in the future, so maybe nvme-tools is good?

manu updated this revision to Diff 109428.Aug 16 2022, 9:27 PM

Rename the package to nvme-tools

Harbormaster completed remote builds in B46980: Diff 109428.Aug 16 2022, 9:28 PM
emaste accepted this revision.Aug 22 2022, 8:05 PM
This revision is now accepted and ready to land.Aug 22 2022, 8:05 PM
Closed by commit rG5f9db65d8af0: pkgbase: Put nvmecontrol in its own package (authored by manu). · Explain WhyOct 26 2022, 5:49 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG5f9db65d8af0: pkgbase: Put nvmecontrol in its own package.
manu added a commit: rGb80ee728d2c4: pkgbase: Put nvmecontrol in its own package.Feb 2 2023, 9:33 AM

Revision Contents
Changeset List

PathSize
release/
packages/
2 lines
sbin/
nvmecontrol/
2 lines
modules/
2 lines

Diff 112218

View Options

release/packages/Makefile.package

Loading...
View Options

sbin/nvmecontrol/Makefile

Loading...
View Options

sbin/nvmecontrol/modules/Makefile.inc

Loading...