Page MenuHomeFreeBSD

Add RockChip rk809/rk817 pmic support to existing RockChip pmic drivers
ClosedPublic

Authored by ganbold on Aug 12 2022, 2:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 12:54 AM
Unknown Object (File)
Sun, Apr 28, 10:22 AM
Unknown Object (File)
Sat, Apr 27, 3:16 PM
Unknown Object (File)
Fri, Apr 26, 3:49 PM
Unknown Object (File)
Feb 18 2024, 1:41 PM
Unknown Object (File)
Feb 11 2024, 1:28 PM
Unknown Object (File)
Feb 11 2024, 8:14 AM
Unknown Object (File)
Feb 11 2024, 8:14 AM
Subscribers

Details

Summary

This patch adds RockChip rk809/rk817 pmic support to existing RockChip pmic drivers.
It was submitted by sos@.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ganbold added a subscriber: andrew.
sys/dev/iicbus/pmic/rockchip/rk8xx.c
123

This part will probably not work on other PMIC as they can't powercycle.

Hopefully fixed accordingly.

Hopefully fixed accordingly.

Before we use to always power off the PMIC , maybe we should still do the same.

In D36149#821860, @manu wrote:

Hopefully fixed accordingly.

Before we use to always power off the PMIC , maybe we should still do the same.

Sorry, what do you mean here? Add similar check for POWEROFF?

In D36149#821860, @manu wrote:

Hopefully fixed accordingly.

Before we use to always power off the PMIC , maybe we should still do the same.

Sorry, what do you mean here? Add similar check for POWEROFF?

Yes, right now if howto == RB_POWERCYCLE we won't do a think for RK3328 or RK3399, we should power off for every PMIC that can't powercycle.

Updated the patch. I hope I understood the comment, correct me if I'm wrong here.

Updated the patch. I hope I understood the comment, correct me if I'm wrong here.

Yup this is what I meant :)

This revision is now accepted and ready to land.Aug 16 2022, 7:46 AM
This revision was automatically updated to reflect the committed changes.