Page MenuHomeFreeBSD
Differential D36149

Add RockChip rk809/rk817 pmic support to existing RockChip pmic drivers
ClosedPublic
Actions

Authored by ganbold on Aug 12 2022, 2:56 AM.
Tags
None
Referenced Files
F157759788: D36149.id109212.diff
Sun, May 24, 10:10 PM
Unknown Object (File)
Wed, May 20, 6:40 PM
Unknown Object (File)
Fri, May 15, 3:10 PM
Unknown Object (File)
Fri, May 15, 2:19 PM
Unknown Object (File)
Fri, May 15, 3:24 AM
Unknown Object (File)
Thu, May 14, 5:28 PM
Unknown Object (File)
Thu, May 14, 4:34 PM
Unknown Object (File)
Thu, May 14, 2:04 AM
View All Files
Subscribers
andrew
imp
sos

Details

Reviewers
manu
Commits
rG66a3e513412a: Add RockChip rk809/rk817 pmic support to existing
Summary

This patch adds RockChip rk809/rk817 pmic support to existing RockChip pmic drivers.
It was submitted by sos@.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ganbold created this revision.Aug 12 2022, 2:56 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 12 2022, 2:56 AM
ganbold requested review of this revision.Aug 12 2022, 2:56 AM
ganbold added a subscriber: andrew.
manu added inline comments.Aug 15 2022, 7:46 AM
sys/dev/iicbus/pmic/rockchip/rk8xx.c
123

This part will probably not work on other PMIC as they can't powercycle.

ganbold updated this revision to Diff 109357.Aug 15 2022, 7:53 AM

Hopefully fixed accordingly.

manu added a comment.Aug 15 2022, 7:56 AM
In D36149#821858, @ganbold wrote:

Hopefully fixed accordingly.

Before we use to always power off the PMIC , maybe we should still do the same.

ganbold added a comment.Aug 16 2022, 6:43 AM
In D36149#821860, @manu wrote:
In D36149#821858, @ganbold wrote:

Hopefully fixed accordingly.

Before we use to always power off the PMIC , maybe we should still do the same.

Sorry, what do you mean here? Add similar check for POWEROFF?

manu added a comment.Aug 16 2022, 7:22 AM
In D36149#822023, @ganbold wrote:
In D36149#821860, @manu wrote:
In D36149#821858, @ganbold wrote:

Hopefully fixed accordingly.

Before we use to always power off the PMIC , maybe we should still do the same.

Sorry, what do you mean here? Add similar check for POWEROFF?

Yes, right now if howto == RB_POWERCYCLE we won't do a think for RK3328 or RK3399, we should power off for every PMIC that can't powercycle.

ganbold updated this revision to Diff 109374.Aug 16 2022, 7:42 AM

Updated the patch. I hope I understood the comment, correct me if I'm wrong here.

manu accepted this revision.Aug 16 2022, 7:46 AM
In D36149#822028, @ganbold wrote:

Updated the patch. I hope I understood the comment, correct me if I'm wrong here.

Yup this is what I meant :)

This revision is now accepted and ready to land.Aug 16 2022, 7:46 AM
Closed by commit rG66a3e513412a: Add RockChip rk809/rk817 pmic support to existing (authored by sos, committed by ganbold). · Explain WhyAug 16 2022, 7:57 AM
This revision was automatically updated to reflect the committed changes.
ganbold added a commit: rG66a3e513412a: Add RockChip rk809/rk817 pmic support to existing.

Revision Contents
Changeset List

PathSize
sys/
dev/
iicbus/
pmic/
rockchip/
532 lines
121 lines
6 lines
15 lines
58 lines
14 lines

Diff 109375

View Options

sys/dev/iicbus/pmic/rockchip/rk817.c

Loading...
View Options

sys/dev/iicbus/pmic/rockchip/rk817reg.h

Loading...
View Options

sys/dev/iicbus/pmic/rockchip/rk8xx.h

Loading...
View Options

sys/dev/iicbus/pmic/rockchip/rk8xx.c

Loading...
View Options

sys/dev/iicbus/pmic/rockchip/rk8xx_regulators.c

Loading...
View Options

sys/dev/iicbus/pmic/rockchip/rk8xx_rtc.c

Loading...