TPM: do not set device description if probe fails
ClosedPublic
Actions

Authored by kjopek_gmail.com on Jul 30 2022, 7:58 AM.

Details

Reviewers

mw
takawata
contact_artur-rojek.eu
kd

Commits

rG91af12081edc: TPM: do not set device description if probe fails
rG31ee3a33aa61: TPM: do not set device description if probe fails

Summary

device_set_desc should be called only if driver probes successfully.

Test Plan

Tested on Asus X390 pro MB where no crb start method is present - only ACPI.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kjopek_gmail.com created this revision.Jul 30 2022, 7:58 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 30 2022, 7:58 AM

kjopek_gmail.com requested review of this revision.Jul 30 2022, 7:58 AM

kjopek_gmail.com added a reviewer: contact_artur-rojek.eu.

mw accepted this revision.Jul 30 2022, 8:59 AM

mw added a reviewer: kd.

This revision is now accepted and ready to land.Jul 30 2022, 8:59 AM

LGTM

Would you like me to commit it?

@kd Feel free to commit it - I have no particular preferences on committer.

Closed by commit rG31ee3a33aa61: TPM: do not set device description if probe fails (authored by kjopek_gmail.com, committed by kd). · Explain WhyAug 16 2022, 9:12 AM

This revision was automatically updated to reflect the committed changes.

kd added a commit: rG31ee3a33aa61: TPM: do not set device description if probe fails.

kd added a commit: rG91af12081edc: TPM: do not set device description if probe fails.Sep 1 2022, 7:22 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

tpm/

tpm_crb.c

2 lines

Diff 108737

View Options

TPM: do not set device description if probe failsClosedPublicActions