Differential D35942

linuxkpi: Add io.h
ClosedPublic
Actions

Authored by manu on Jul 26 2022, 9:32 AM.

Tags

None

Referenced Files

	F166330981: D35942.id108800.diff
	Wed, Aug 12, 11:15 PM

	Unknown Object (File)
	Tue, Aug 11, 8:24 PM

	Unknown Object (File)
	Tue, Aug 11, 7:46 PM

	Unknown Object (File)
	Mon, Aug 10, 8:34 PM

	Unknown Object (File)
	Mon, Aug 10, 3:17 PM

	Unknown Object (File)
	Mon, Aug 10, 3:16 PM

	Unknown Object (File)
	Mon, Aug 10, 4:20 AM

	Unknown Object (File)
	Sun, Aug 9, 2:33 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rG96c30348bda0: linuxkpi: Add io.h
rG96b917bfcf2c: linuxkpi: Add io.h

Summary

out* arguments are different on Linux and the i915 driver uses them.
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Jul 26 2022, 9:32 AM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptJul 26 2022, 9:32 AM

manu requested review of this revision.Jul 26 2022, 9:32 AM

Harbormaster completed remote builds in B46589: Diff 108543.Jul 26 2022, 9:32 AM

manu added a reviewer: linuxkpi.Jul 26 2022, 9:34 AM

This looks pretty scary. Can you make sure that this file includes the file defining outb() and outw() and outl() first?

And that this file is not included anywhere else?

--HPS

bz added a subscriber: bz.Jul 28 2022, 10:06 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/asm-generic/io.h
30	Do we need to put all, including the #include into ... given we don't do per-arch asm/? #if defined(i386) \|\| defined(amd64) #include <machine/cpufunc.h> /* and possibly other dependencies? */ ... #endif

Only add this for x86

Harbormaster completed remote builds in B46709: Diff 108797.Aug 2 2022, 7:41 AM

Fix by using correct names for the arches.

Harbormaster completed remote builds in B46712: Diff 108800.Aug 2 2022, 8:01 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2022, 2:06 PM

Closed by commit rG96b917bfcf2c: linuxkpi: Add io.h (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG96b917bfcf2c: linuxkpi: Add io.h.

manu added a commit: rG96c30348bda0: linuxkpi: Add io.h.Sep 7 2022, 3:12 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

asm-generic/

40 lines

Diff 108991

sys/compat/linuxkpi/common/include/asm-generic/io.h

Loading...