Page MenuHomeFreeBSD
Differential D35889

Mk/Uses/compiler.mk: Support newer C++ standards
ClosedPublic
Actions

Authored by zirias on Jul 24 2022, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 27, 10:01 AM
Unknown Object (File)
Sun, Oct 26, 1:41 PM
Unknown Object (File)
Sat, Oct 25, 9:11 PM
Unknown Object (File)
Sat, Oct 25, 5:29 AM
Unknown Object (File)
Thu, Oct 23, 2:08 PM
Unknown Object (File)
Thu, Oct 23, 2:08 PM
Unknown Object (File)
Thu, Oct 23, 2:08 PM
Unknown Object (File)
Thu, Oct 23, 2:08 PM
View All Files
Subscribers
mat

Details

Reviewers
jrm
bapt
tcberner
Group Reviewers
portmgr
Commits
R11:5ca22080ae08: Mk/Uses/compiler.mk: Support newer C++ standards
Summary
  • Add c++20-lang and c++2b-lang arguments
  • Respect LLVM_DEFAULT if it fullfills the requirements

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 46519
Build 43408: arc lint + arc unit

Event Timeline

zirias created this revision.Jul 24 2022, 12:45 PM
Herald added a reviewer: portmgr. · View Herald TranscriptJul 24 2022, 12:45 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B46519: Diff 108448.Jul 24 2022, 12:45 PM
zirias requested review of this revision.Jul 24 2022, 12:45 PM
zirias added a comment.Jul 24 2022, 12:47 PM

Remark: I'm not too sure about the support for newer C++ standards as this would probably also require support in STL/libstdc++...

But I really think compiler.mk should respect LLVM_DEFAULT when pulling in llvm from ports? Would of course require intensive testing!

zirias updated this revision to Diff 108450.Jul 24 2022, 1:01 PM

Fix min version for llvm

Checking for c++2b-lang must happen before c++20-lang to "win" regarding
the min version of llvm required.

Harbormaster completed remote builds in B46521: Diff 108450.Jul 24 2022, 1:01 PM
zirias updated this revision to Diff 108461.Jul 24 2022, 4:41 PM

Extend VALID_ARGS

forgot that ....

Harbormaster completed remote builds in B46524: Diff 108461.Jul 24 2022, 4:41 PM
bapt accepted this revision.Aug 24 2022, 6:58 AM

imho worth an exp-run

This revision is now accepted and ready to land.Aug 24 2022, 6:58 AM
tcberner accepted this revision.Sep 11 2022, 11:31 AM

ship it

Closed by commit R11:5ca22080ae08: Mk/Uses/compiler.mk: Support newer C++ standards (authored by zirias). · Explain WhySep 11 2022, 11:36 AM
This revision was automatically updated to reflect the committed changes.
zirias added a commit: R11:5ca22080ae08: Mk/Uses/compiler.mk: Support newer C++ standards.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
39 lines

Diff 108448

View Options

Mk/Uses/compiler.mk

Loading...