Page MenuHomeFreeBSD

Use the compiler driver instead of ${AS}
ClosedPublic

Authored by emaste on Jul 19 2022, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 26 2023, 5:57 PM
Unknown Object (File)
Dec 20 2023, 8:09 AM
Unknown Object (File)
Dec 19 2023, 4:43 PM
Unknown Object (File)
Nov 27 2023, 7:34 PM
Unknown Object (File)
Jun 26 2023, 2:05 AM
Unknown Object (File)
Jun 22 2023, 7:21 PM
Unknown Object (File)
May 9 2023, 3:57 AM
Unknown Object (File)
May 3 2023, 10:23 PM

Details

Summary

As of commit fd71da37d478 we no longer have an as in the default toolchain and there is no value in keeping rules that use it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Yea, we have all .S files at this point

This revision is now accepted and ready to land.Jul 20 2022, 3:01 AM

Note that D35864 needs to be addressed before this could be committed, and I think this warrants an exp-run as well.

Maybe the rules for .s files should be updated to compile them using CC instead?

Maybe the rules for .s files should be updated to compile them using CC instead?

Yeah @jrtc27 also made that suggestion in D35864 and it makes sense; I will update. Although nothing in the base system uses the .s.o rules now there may be ports that do and it doesn't hurt to have the rules still.

share/mk/bsd.compat.mk
40

This can be removed either way, since we won't use $AS in the base system

emaste retitled this revision from Remove ${AS} make rules to Use the compiler driver instead of ${AS}.
  • replace as rules with cc -x assembler
This revision now requires review to proceed.Jul 26 2022, 4:56 PM

I think the -x flag is not required since that is the default for .s but I don't think it does any harm.

This revision is now accepted and ready to land.Jul 26 2022, 9:25 PM
This revision was automatically updated to reflect the committed changes.