Differential D35671
rb_tree: silence coverity Authored by dougm on Jun 30 2022, 7:57 AM. Tags None Referenced Files
Subscribers
Details RB_INSERT_COLOR has a variable, child, that is not initialized, and Coverity believes that it may be used before a value is assigned to it. It's not possible. Assigning 'NULL' as an initial value would silence coverity, but if coverity was right about the need to initialize, then it would lead to a null pointer dereference. But coverity is wrong. So, add comments to suppress the uninit_use warnings that coverity is generating for the use of 'child' in RB_INSERT_COLOR. I have no way to test this.
Diff Detail
Event TimelineComment Actions This looks like it ought to work, but I don't have any experience with these kinds of annotations. I note that scan-build (LLVM's static analyzer) reports the same "problem." It might be useful to include a brief comment explaining why child is always initialized before use. Comment Actions Add a 'brief' comment. I don't seem to have any 'scan-build' executable to test this with. Comment Actions I believe it doesn't get built with the FreeBSD base system by default, one has to specify WITH_CLANG_EXTRAS. Alternately, pkg install llvm will install it to /usr/local/bin. Here's some example output: https://reviews.freebsd.org/P543 |