Drop d_dump from struct cdevsw
ClosedPublic
Actions

Authored by mhorne on May 11 2022, 3:10 PM.

Tags

None

Referenced Files

	F132699661: D35172.id105859.diff
	Sun, Oct 19, 3:58 AM

	Unknown Object (File)
	Mon, Oct 13, 10:44 AM

	Unknown Object (File)
	Mon, Oct 13, 10:44 AM

	Unknown Object (File)
	Mon, Oct 13, 10:44 AM

	Unknown Object (File)
	Mon, Oct 13, 10:44 AM

	Unknown Object (File)
	Sun, Oct 12, 10:13 PM

	Unknown Object (File)
	Sun, Oct 5, 3:56 AM

	Unknown Object (File)
	Aug 31 2025, 11:21 AM

View All 96 Files

Subscribers

None

Details

Reviewers

markj
imp
jhb

Commits

rG6350ace614fc: Drop d_dump from struct cdevsw
rG0f50da2e09b7: Drop d_dump from struct cdevsw

Summary

It appears to be unused. These days struct disk has a d_dump member,
which is what gets passed to the kernel dump framework.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne requested review of this revision.May 11 2022, 3:10 PM

mhorne created this revision.

Harbormaster completed remote builds in B45528: Diff 105858.May 11 2022, 3:10 PM

Fix a typo: void ** -> void *

Harbormaster completed remote builds in B45529: Diff 105859.May 11 2022, 3:13 PM

markj accepted this revision.May 12 2022, 1:00 PM

This revision is now accepted and ready to land.May 12 2022, 1:00 PM

Closed by commit rG0f50da2e09b7: Drop d_dump from struct cdevsw (authored by mhorne). · Explain WhyMay 13 2022, 1:45 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG0f50da2e09b7: Drop d_dump from struct cdevsw.

mhorne added a commit: rG6350ace614fc: Drop d_dump from struct cdevsw.May 27 2022, 4:24 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_conf.c

7 lines

sys/

conf.h

8 lines

Diff 105941

View Options

sys/kern/kern_conf.c