Differential D35092

mpr/mps: when sending reset on removal, include target in message
ClosedPublic
Actions

Authored by imp on Apr 28 2022, 7:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 3, 9:23 AM

	Unknown Object (File)
	Sun, Dec 29, 12:43 AM

	Unknown Object (File)
	Thu, Dec 19, 3:19 AM

	Unknown Object (File)
	Wed, Dec 18, 1:06 AM

	Unknown Object (File)
	Sun, Dec 8, 1:11 PM

	Unknown Object (File)
	Nov 20 2024, 9:06 AM

	Unknown Object (File)
	Oct 5 2024, 9:04 PM

	Unknown Object (File)
	Sep 30 2024, 1:54 AM

View All 73 Files

Subscribers

None

Details

Reviewers

slm
mav
ken

Commits

rGaea9f26d8005: mpr/mps: when sending reset on removal, include target in message
rGca420b4ef2ce: mpr/mps: when sending reset on removal, include target in message

Summary

It's possible for muliple drives to be departing at the same time (if
the common power rail the share goes dark, for example). To understand
what's going on better, include target and handle in the messages
announcing the reset to allow matching with other corresponding events.

MFC After: 3 days
Sponsored by: Netflix

Test Plan

I noticed this when I was unwinding messages looking for device departure bugs...

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 28 2022, 7:48 PM

Herald added a reviewer: slm. · View Herald TranscriptApr 28 2022, 7:48 PM

imp requested review of this revision.Apr 28 2022, 7:48 PM

Harbormaster completed remote builds in B45421: Diff 105538.Apr 28 2022, 7:48 PM

imp added a child revision: D35093: cam_periph: Return ENXIO when peripheral is invalidated.Apr 28 2022, 7:48 PM

imp edited the test plan for this revision. (Show Details)Apr 28 2022, 8:18 PM

imp added reviewers: mav, ken.

mav accepted this revision.Apr 28 2022, 8:38 PM

This revision is now accepted and ready to land.Apr 28 2022, 8:38 PM

Closed by commit rGca420b4ef2ce: mpr/mps: when sending reset on removal, include target in message (authored by imp). · Explain WhyApr 28 2022, 10:31 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGca420b4ef2ce: mpr/mps: when sending reset on removal, include target in message.

imp added a commit: rGaea9f26d8005: mpr/mps: when sending reset on removal, include target in message.Sat, Dec 28, 6:01 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mpr/

8 lines

mps/

8 lines

Diff 105540

sys/dev/mpr/mpr_sas.c

Loading...

sys/dev/mps/mps_sas.c

Loading...