sched_getaffinity(3): more compatibility with Linux
ClosedPublic
Actions

Authored by kib on Apr 24 2022, 10:13 PM.

Details

Reviewers

jhb
dchagin
markj

Commits

rG67fc95025ccf: sched_getaffinity(3): more compatibility with Linux

Summary

Report EINVAL instead of EDEADLK when impossible cpu mask is set.

Noted by: dchagin

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Apr 24 2022, 10:13 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 24 2022, 10:13 PM

kib requested review of this revision.Apr 24 2022, 10:13 PM

kib mentioned this in D34850: linux(4); Adopt affinity syscalls to the recent kernel changes..

btw, glibc defines CPU_SETSIZE as 1024 https://sourceware.org/git/?p=glibc.git;a=blob;f=posix/bits/cpu-set.h;h=afc1622f7ea4063ea1bd84e20d491d72e378376c;hb=refs/heads/master
so if the storage for cpu_set_t is not allocated by CPU_ALLOC with count = 256 our sched_setaffinity should fails

This revision is now accepted and ready to land.Apr 25 2022, 7:01 AM

markj added inline comments.Apr 25 2022, 1:18 PM

lib/libc/gen/sched_setaffinity.c
49	Don't we have to check and set `errno`, not `error`?

Fix error/errno meh.

This revision now requires review to proceed.Apr 25 2022, 1:22 PM

kib marked an inline comment as done.Apr 25 2022, 1:22 PM

markj accepted this revision.Apr 25 2022, 1:25 PM

This revision is now accepted and ready to land.Apr 25 2022, 1:25 PM

Closed by commit rG67fc95025ccf: sched_getaffinity(3): more compatibility with Linux (authored by kib). · Explain WhyApr 25 2022, 2:23 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG67fc95025ccf: sched_getaffinity(3): more compatibility with Linux.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

sched_setaffinity.c

9 lines

Diff 105399

View Options

lib/libc/gen/sched_setaffinity.c

sched_getaffinity(3): more compatibility with LinuxClosedPublicActions