Page MenuHomeFreeBSD

bsdinstall/partedit: fix UFS auto partitioning
ClosedPublic

Authored by asiciliano on Apr 23 2022, 5:25 AM.

Details

Summary

Fix bsdinstall "Auto (UFS) Guided Disk Setup" and sade(8) "Auto" button.

Probably this should solve: https://lists.freebsd.org/archives/freebsd-current/2022-April/001851.html
I had a different error message during installation (bsdinstall/partedit) and a segmentation fault with sade locally.
Problem causes: 1) dialog does not differentiate between form.init and form.value, 2) dialog always allocates memory for the value while bsddialog only when a key is pressed.

Test Plan

I created 2 disks in virtualbox: the first to install the OS and the second to test [Auto] button.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Minor nit.

usr.sbin/bsdinstall/partedit/gpart_ops.c
1161

Isn't indentation wrong here?

asiciliano edited the summary of this revision. (Show Details)
asiciliano edited the test plan for this revision. (Show Details)

Fixed, thank you.

asiciliano added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1161

fixed, thank you.

asiciliano added a reviewer: nwhitehorn.
This revision is now accepted and ready to land.Apr 29 2022, 4:49 PM
This revision was automatically updated to reflect the committed changes.
asiciliano marked an inline comment as done.