Page MenuHomeFreeBSD

Remove PAGE_SIZE from the kcov tests
Needs ReviewPublic

Authored by andrew on Apr 21 2022, 10:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 28, 11:48 PM
Unknown Object (File)
Tue, Apr 28, 6:50 AM
Unknown Object (File)
Tue, Apr 28, 3:54 AM
Unknown Object (File)
Mon, Apr 27, 6:08 PM
Unknown Object (File)
Apr 24 2026, 7:01 PM
Unknown Object (File)
Apr 18 2026, 10:34 PM
Unknown Object (File)
Apr 5 2026, 8:40 PM
Unknown Object (File)
Mar 25 2026, 8:19 AM
Subscribers
None

Details

Summary

To allow for a dynamic page size on arm64 remove the static valud from
the kcov tests

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45296
Build 42184: arc lint + arc unit

Event Timeline

andrew created this revision.

The ATF header isn't really supposed to be used this way: it's executed even when the test itself is not, so kyua will run this code when interrogating tests for their metadata. See atf-test-case.4. Instead of having a header for each test which wants to know the page size, perhaps have

static size_t
pagesize(void)
{
    static int ps = 0;

    if (ps == 0)
         ps = getpagesize();
    return (ps);
}

and make each test call it where it uses page_size now?