Page MenuHomeFreeBSD

Remove PAGE_SIZE from the kcov tests
Needs ReviewPublic

Authored by andrew on Apr 21 2022, 10:02 AM.
Tags
None
Referenced Files
F100670695: D35020.id.diff
Fri, Oct 18, 4:06 AM
Unknown Object (File)
Tue, Oct 1, 1:30 PM
Unknown Object (File)
Tue, Sep 24, 12:53 PM
Unknown Object (File)
Sep 5 2024, 7:29 AM
Unknown Object (File)
Jul 30 2024, 12:32 PM
Unknown Object (File)
Jul 27 2024, 3:59 AM
Unknown Object (File)
Jul 11 2024, 3:16 PM
Unknown Object (File)
Jun 28 2024, 3:30 PM
Subscribers
None

Details

Summary

To allow for a dynamic page size on arm64 remove the static valud from
the kcov tests

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45296
Build 42184: arc lint + arc unit

Event Timeline

andrew created this revision.

The ATF header isn't really supposed to be used this way: it's executed even when the test itself is not, so kyua will run this code when interrogating tests for their metadata. See atf-test-case.4. Instead of having a header for each test which wants to know the page size, perhaps have

static size_t
pagesize(void)
{
    static int ps = 0;

    if (ps == 0)
         ps = getpagesize();
    return (ps);
}

and make each test call it where it uses page_size now?