Page MenuHomeFreeBSD

Remove PAGE_SIZE from the kcov tests
Needs ReviewPublic

Authored by andrew on Apr 21 2022, 10:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 8, 4:00 AM
Unknown Object (File)
Tue, Sep 8, 2:25 AM
Unknown Object (File)
Mon, Sep 7, 4:42 AM
Unknown Object (File)
Sun, Sep 6, 6:45 PM
Unknown Object (File)
Sun, Sep 6, 2:28 PM
Unknown Object (File)
Sun, Sep 6, 7:27 AM
Unknown Object (File)
Sat, Sep 5, 4:38 PM
Unknown Object (File)
Sat, Sep 5, 3:21 AM
Subscribers
None

Details

Summary

To allow for a dynamic page size on arm64 remove the static valud from
the kcov tests

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45296
Build 42184: arc lint + arc unit

Event Timeline

andrew created this revision.

The ATF header isn't really supposed to be used this way: it's executed even when the test itself is not, so kyua will run this code when interrogating tests for their metadata. See atf-test-case.4. Instead of having a header for each test which wants to know the page size, perhaps have

static size_t
pagesize(void)
{
    static int ps = 0;

    if (ps == 0)
         ps = getpagesize();
    return (ps);
}

and make each test call it where it uses page_size now?