Differential D34934

sbin/devfs: Correct usage
ClosedPublic
Actions

Authored by zlei on Apr 16 2022, 4:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 20, 5:55 AM

	Unknown Object (File)
	Mon, Oct 13, 6:17 AM

	Unknown Object (File)
	Mon, Oct 13, 6:17 AM

	Unknown Object (File)
	Mon, Oct 13, 6:16 AM

	Unknown Object (File)
	Sun, Oct 12, 6:15 PM

	Unknown Object (File)
	Thu, Oct 9, 6:30 AM

	Unknown Object (File)
	Sat, Oct 4, 7:44 PM

	Unknown Object (File)
	Sep 11 2025, 8:11 PM

View All 89 Files

Subscribers

naito.yuichiro_gmail.com

Details

Reviewers

ngie
hrs

Commits

rGac3223a57e11: sbin/devfs: Correct usage
rG66b882078973: sbin/devfs: Correct usage
rGf9f42a709b2b: sbin/devfs: Correct usage

Summary

The -s applies to rule keyword only and it follows the rule keyword.

PR: 263289
Submitted by: Yuichiro NAITO <naito.yuichiro@gmail.com>
Fixes: c3e412c08333 sbin/devfs: clarify usage

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Apr 16 2022, 4:58 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 16 2022, 4:58 AM

zlei requested review of this revision.Apr 16 2022, 4:58 AM

zlei edited the summary of this revision. (Show Details)Apr 16 2022, 5:13 AM

naito.yuichiro_gmail.com added a subscriber: naito.yuichiro_gmail.com.Apr 19 2022, 9:04 AM

zlei added a reviewer: hrs.Apr 24 2022, 1:38 AM

ngie accepted this revision.Apr 30 2022, 5:48 PM

This revision is now accepted and ready to land.Apr 30 2022, 5:48 PM

Closed by commit rGf9f42a709b2b: sbin/devfs: Correct usage (authored by ngie). · Explain WhyApr 30 2022, 6:00 PM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rGf9f42a709b2b: sbin/devfs: Correct usage.

In retrospect, I should have removed/edited the metadata in the commit message. It looks nice on Phabricator, but it looks less nice in raw git/email form.

In D34934#795609, @ngie wrote:

In retrospect, I should have removed/edited the metadata in the commit message. It looks nice on Phabricator, but it looks less nice in raw git/email form.

I'm OK with this, except that the commit message contains full URL of PR. I thinks a single PR id is enough.

Hi @ngie ,
will this be MFCed to stable branches ? stable/13 and stable/12 also have this issue.

Ping .

zlei added a commit: rG66b882078973: sbin/devfs: Correct usage.Feb 3 2023, 3:58 PM

zlei added a commit: rGac3223a57e11: sbin/devfs: Correct usage.Feb 3 2023, 4:01 PM

Revision Contents
Changeset List

Path

Size

sbin/

devfs/

2 lines

Diff 105612

sbin/devfs/devfs.c

Loading...