Differential D34893

net80211: remove (optional) RSN from preobereq
ClosedPublic
Actions

Authored by bz on Apr 12 2022, 10:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 30, 7:06 AM

	Unknown Object (File)
	Tue, Apr 29, 10:07 AM

	Unknown Object (File)
	Tue, Apr 29, 8:58 AM

	Unknown Object (File)
	Fri, Apr 25, 7:32 AM

	Unknown Object (File)
	Apr 16 2025, 7:41 PM

	Unknown Object (File)
	Feb 21 2025, 4:41 PM

	Unknown Object (File)
	Feb 15 2025, 2:32 AM

	Unknown Object (File)
	Feb 5 2025, 2:04 AM

View All 55 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rG1e80cda00210: net80211: remove (optional) RSN from preobereq
rG892b1874ace0: net80211: remove (optional) RSN from preobereq

Summary

802.11i-2004 did not specify that RSN can be added to the probereq,
only to the proberesp (and others) yet it was added in what seems was
b032f27c365b992e9d8e42214183b39acfb8c6ac (multi-BSS support).
802.11-2020 does not list the IE either for probereq so remove it.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Apr 12 2022, 10:05 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptApr 12 2022, 10:05 PM

bz requested review of this revision.Apr 12 2022, 10:05 PM

Harbormaster completed remote builds in B45137: Diff 104937.Apr 12 2022, 10:05 PM

Any comment on this one?

I think it's okay to remove it. Just make sure it doesn't break adhoc mode 11n rate "negotiation" stuff.

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 10:37 PM

Closed by commit rG892b1874ace0: net80211: remove (optional) RSN from preobereq (authored by bz). · Explain Why

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG892b1874ace0: net80211: remove (optional) RSN from preobereq.

bz added a commit: rG1e80cda00210: net80211: remove (optional) RSN from preobereq.Jun 3 2022, 5:19 PM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_output.c

4 lines

Diff 106121

sys/net80211/ieee80211_output.c

Loading...