Page MenuHomeFreeBSD
Differential D34853

vm_phys_early_alloc: mem_index is only used under #ifdef NUMA.
ClosedPublic
Actions

Authored by jhb on Apr 8 2022, 10:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 8:30 PM
Unknown Object (File)
Oct 22 2025, 10:05 PM
Unknown Object (File)
Oct 17 2025, 6:14 AM
Unknown Object (File)
Oct 17 2025, 6:14 AM
Unknown Object (File)
Oct 17 2025, 4:36 AM
Unknown Object (File)
Oct 16 2025, 8:49 PM
Unknown Object (File)
Oct 13 2025, 4:31 AM
Unknown Object (File)
Oct 10 2025, 9:47 PM
View All 61 Files
Subscribers
imp

Details

Reviewers
markj
kib
Commits
rG2e7838ae84c6: vm_phys_early_alloc: mem_index is only used under #ifdef NUMA.
Summary

Possibly mem_index should just reuse biggestone since this loop is
already reusing biggestsize.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45087
Build 41975: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 8 2022, 10:59 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 8 2022, 10:59 PM
jhb requested review of this revision.Apr 8 2022, 10:59 PM
Harbormaster completed remote builds in B45087: Diff 104790.Apr 8 2022, 10:59 PM
kib accepted this revision.Apr 9 2022, 12:38 AM
kib added inline comments.
sys/vm/vm_phys.c
1681

Or do int mem_index = 0; there; style now allows it.

This revision is now accepted and ready to land.Apr 9 2022, 12:38 AM
jhb closed this revision.Apr 9 2022, 1:16 AM
jhb added a commit: rG2e7838ae84c6: vm_phys_early_alloc: mem_index is only used under #ifdef NUMA..

Oops, I had merged this accidentally along with other commits before it was reviewed.

Revision Contents
Changeset List

PathSize
sys/
vm/
7 lines

Diff 104790

View Options

sys/vm/vm_phys.c

Loading...