Page MenuHomeFreeBSD
Differential D3485

Fix several set but not used variables spotted by GCC.
AbandonedPublic
Actions

Authored by araujo on Aug 26 2015, 12:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 1:04 AM
Unknown Object (File)
Mar 22 2023, 6:25 PM
Unknown Object (File)
Mar 5 2023, 5:35 PM
Unknown Object (File)
Apr 24 2017, 12:52 AM
Unknown Object (File)
Apr 4 2017, 6:51 AM
Unknown Object (File)
Dec 8 2016, 6:56 AM
Unknown Object (File)
Oct 29 2016, 9:02 AM
Unknown Object (File)
Jul 24 2016, 5:23 AM
View All 30 Files
Subscribers
imp

Details

Reviewers
• rodrigc
kib
bapt
Summary

It is a remake of the previous review: D2692

NOTE: Instead to make a big patch for libc, I will work and check every each case.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 237
Build 237: arc lint + arc unit

Event Timeline

araujo updated this revision to Diff 8213.Aug 26 2015, 12:55 AM
araujo retitled this revision from to Fix several set but not used variables spotted by GCC..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptAug 26 2015, 12:55 AM
araujo added reviewers: • rodrigc, bapt, kib.Aug 26 2015, 12:57 AM
kib requested changes to this revision.Aug 26 2015, 6:59 AM
kib edited edge metadata.

This is completely wrong. Read how va_arg() works.

This revision now requires changes to proceed.Aug 26 2015, 6:59 AM
araujo abandoned this revision.Aug 27 2015, 2:55 AM

OK, Agreed with @kib, it is really wrong: The va_arg() macro returns the value of the next argument.

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
20 lines
17 lines

Diff 8213

View Options

lib/libc/gen/getgrent.c

Loading...
View Options

lib/libc/gen/getpwent.c

Loading...