Fix several set but not used variables spotted by GCC.
AbandonedPublic
Actions

Authored by araujo on Aug 26 2015, 12:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 10, 9:47 PM

	Unknown Object (File)
	Wed, Sep 10, 10:52 AM

	Unknown Object (File)
	Thu, Sep 4, 9:18 AM

	Unknown Object (File)
	Thu, Sep 4, 8:38 AM

	Unknown Object (File)
	Jul 1 2025, 2:59 PM

	Unknown Object (File)
	Jun 29 2025, 10:21 AM

	Unknown Object (File)
	Jun 26 2025, 10:06 AM

	Unknown Object (File)
	Jun 24 2025, 3:16 AM

View All 53 Files

Subscribers

imp

Details

Reviewers

• rodrigc
kib
bapt

Summary

It is a remake of the previous review: D2692

NOTE: Instead to make a big patch for libc, I will work and check every each case.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 237
Build 237: arc lint + arc unit

Event Timeline

araujo updated this revision to Diff 8213.Aug 26 2015, 12:55 AM

araujo retitled this revision from to Fix several set but not used variables spotted by GCC..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptAug 26 2015, 12:55 AM

araujo added reviewers: • rodrigc, bapt, kib.Aug 26 2015, 12:57 AM

This is completely wrong. Read how va_arg() works.

This revision now requires changes to proceed.Aug 26 2015, 6:59 AM

OK, Agreed with @kib, it is really wrong: The va_arg() macro returns the value of the next argument.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

getgrent.c

20 lines

getpwent.c

17 lines

Diff 8213

View Options

lib/libc/gen/getgrent.c