Base of autoloading stuff
ClosedPublic
Actions

Authored by imp on Aug 22 2015, 3:57 PM.

Details

Reviewers

Summary

Create the MDT_PNP_INFO metadata record to communicate PNP info about
modules. External agents may use this data to automatically load those
modules.

Augment kldxref to find the new MODULE_PNP_INFO records now in
modules, simplify them into a more normal form and write them to
linker.hints.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 292
Build 292: arc lint + arc unit

Event Timeline

imp updated this revision to Diff 8130.Aug 22 2015, 3:57 PM

imp retitled this revision from to Base of autoloading stuff.

imp updated this object.

imp edited the test plan for this revision. (Show Details)

imp added a reviewer: kib.Aug 22 2015, 4:00 PM

imp mentioned this in D3458: Create initial review for the automatic PNP work..Aug 22 2015, 4:02 PM

Looks promising. Can you declare tables which can also be used by device_probe callbacks like with the current USB PnP tables?

sys/sys/module.h
176	Parenthesis the macro arguments? Some style: <tab> after #define ?

In D3461#70624, @hselasky wrote:

Looks promising. Can you declare tables which can also be used by device_probe callbacks like with the current USB PnP tables?

Yes. You can declare as many tables as you want. Unless I'm not understanding something. I thought I'd flagged them all.

imp added inline comments.Aug 22 2015, 8:27 PM

sys/sys/module.h
176	Noted. I'm not 100% sure that parens are needed. And for #b it would be disastrous. I'll think about it. I'll fix the tab.

bapt added a subscriber: bapt.Aug 23 2015, 10:13 AM

Updates for kib's feedback.

I am fine with the updated code, but IMO the whole infrastructure work should be finished and one or two sample drivers should be converted to auto-loading before this can be judged.

This revision is now accepted and ready to land.Aug 29 2015, 10:17 AM

In D3461#72245, @kib wrote:

I am fine with the updated code, but IMO the whole infrastructure work should be finished and one or two sample drivers should be converted to auto-loading before this can be judged.

Drivers just need to mark their PNP info. Please see review D3458 for the conversion for all the PC Card drivers, all the USB drivers and if_ed.

In D3461#72368, @imp wrote:

Drivers just need to mark their PNP info. Please see review D3458 for the conversion for all the PC Card drivers, all the USB drivers and if_ed.

I was not precise enough. I mean the full loop of working autoloading.

This was committed a long time ago...