Page MenuHomeFreeBSD

Accept multiple programs in bsd.prog.mk and remove bsd.progs.mk
AbandonedPublic

Authored by bapt on Aug 20 2015, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 14 2024, 8:10 PM
Unknown Object (File)
Sep 19 2024, 1:57 AM
Unknown Object (File)
Sep 19 2024, 1:57 AM
Unknown Object (File)
Sep 19 2024, 1:47 AM
Unknown Object (File)
Sep 7 2024, 10:16 AM
Unknown Object (File)
Sep 7 2024, 6:07 AM
Unknown Object (File)
Jul 23 2024, 6:27 AM
Unknown Object (File)
Jul 22 2024, 7:38 AM
Subscribers

Details

Reviewers
ngie
imp
Summary

bsd.progs.mk is wrong in many places. and for example install multiple times the
same things.

Instread turn bsd.prog.mk into a multiprogram version which:
1/ is compatible with the usual way of single programs
2/ Allow per program manpage definitions (simplifying conditional knobs on

program if needed)

3/ Allow per program bindir

All CFLAGS and CXXFLAGS are shared among programs (impossible to make per
program flags in my opinion it is not a big issue as not wildly used.)
DPADD/LDADD/LIBADD are shared accross programs
specific DPADD.prog LDADD.prog can be specified

BINDIR is shared among programs but can be overwritten per program
DEBUGDIR is shared and automatically built as before, but can be overwritten per
program

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 172
Build 172: arc lint + arc unit

Event Timeline

bapt retitled this revision from to Accept multiple programs in bsd.prog.mk and remove bsd.progs.mk.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added reviewers: ngie, imp.

Note that I haven't yet tested a full build (just locale testing) but I would like to get an initiale review on the direction before going further

imp edited edge metadata.

This looks generally good. I haven't nit-picked it since most of the nits are pre-existing conditions. Other than the horrible BINDIR thing, I resisted...

share/mk/bsd.prog.mk
71

What's going on with this bit of nonsense then?

I know it isn't part of this change, but I'd like to understand it...

This revision is now accepted and ready to land.Aug 21 2015, 3:12 PM

Not in this state it is broken by the fact that I cannot specify cflags/ldflags per prog and I have no idea how to fix that yet

@bdrewery's rP288158 should have fixed bsd.progs.mk