Paths

Table of Contentst

Differential D34375

vfs_unregister: fix error handling
ClosedPublic
Actions

Authored by vangyzen on Feb 25 2022, 3:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 14, 10:13 PM

	Unknown Object (File)
	Tue, Apr 14, 10:38 AM

	Unknown Object (File)
	Sat, Apr 11, 8:25 PM

	Unknown Object (File)
	Fri, Apr 10, 12:44 AM

	Unknown Object (File)
	Wed, Apr 1, 2:33 AM

	Unknown Object (File)
	Mon, Mar 30, 10:15 AM

	Unknown Object (File)
	Sun, Mar 29, 6:57 PM

	Unknown Object (File)
	Sat, Mar 28, 7:06 AM

Subscribers

Details

Reviewers

kib
markj
rang_acm.org

Commits

rG769f1e79f58b: vfs_unregister: fix error handling
rG1517b8d5a7f5: vfs_unregister: fix error handling

Summary

Due to misplaced braces, an error from vfs_uninit() in the VFCF_SBDRY
case was ignored.

Reported by: Anton Rang <rang@acm.org>
MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vangyzen created this revision.Feb 25 2022, 3:41 PM

Herald added subscribers: dab, badger, imp. · View Herald TranscriptFeb 25 2022, 3:41 PM

vangyzen requested review of this revision.Feb 25 2022, 3:41 PM

Harbormaster completed remote builds in B44575: Diff 103227.Feb 25 2022, 3:41 PM

markj accepted this revision.Feb 25 2022, 3:44 PM

This revision is now accepted and ready to land.Feb 25 2022, 3:44 PM

rang_acm.org accepted this revision.Feb 25 2022, 4:08 PM

Because of this bug, the nfs VFS module was incorrectly unloaded. However, the nfscl module still refused to unload, so the result was mostly harmless, meaning the kernel didn't panic. The worst effect was, NFS was no longer listed as a VFS, so no NFS mounts could be created until the next reboot. Amusingly, kldload failed with EOPNOTSUPP before and after the fix, so I had to use dtrace to see the difference.

Closed by commit rG1517b8d5a7f5: vfs_unregister: fix error handling (authored by marvin.ma_dell.com, committed by vangyzen). · Explain WhyFeb 25 2022, 6:21 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rG1517b8d5a7f5: vfs_unregister: fix error handling.

vangyzen added a commit: rG769f1e79f58b: vfs_unregister: fix error handling.Mar 3 2022, 2:22 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

3 lines

Diff 103235

sys/kern/vfs_init.c

Loading...